Skip to content

Dependency on @embroider/macros 1.17.3 in v8.6.1 may cause errors for older apps #967

@gorner

Description

@gorner

PR #949 (included in v8.6.1) updated @embroider/macros to ^1.17.3. Unfortunately @embroider/macros 1.17 introduced a change that may break apps using older Ember and/or Ember Data, as described in embroider-build/embroider#2440. I'm guessing the issue is with Ember Data <=4.x, which is understandably not included in your ember-try matrix as ED isn't needed for BasicDropdown.

Just wanted to call it out for the record in case anyone else runs into this. Not the biggest issue for me at least if you can't or decide not to roll macros back, as my app should be on ED 5.x soon enough :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions