Remove use of ember-lifeline#1002
Conversation
|
Will look into the failures asap. Sounds like something is not awaited properly, or I need to re-add a runloop call somewhere. Not sure why it only fails for beta and canary though. |
|
@bertdeblock can you maybe tell me in which version you are getting warnings from from Is this deprecation starting with a beta or canary? At all its good to remove this package, when this is not anymore maintained. |
|
|
|
More specifically, this one => https://deprecations.emberjs.com/id/deprecate-import-testing-from-ember/ |
|
It seems the failures happen on master as well => https://github.com/bertdeblock/ember-basic-dropdown/actions/runs/17544744717, so maybe it's some kind of regression in |
dfa9093 to
b0809b4
Compare
|
Seems beta hasn't received the fix yet, will ask on Discord. |
|
LGTM! thank you... for merging i would just wait , until fix is released in ember-beta if it's okay |
|
@mkszepp Sure, no problem. Thanks for the review! |
|
@bertdeblock released in |
ember-lifelineis unmaintained, and is already triggering deprecation warnings in newer Ember versionsember-basic-dropdownis widely used, so the less dependencies the better