diff --git a/docs/app/templates/public-pages/docs/migrate-8-0-to-9-0.gts b/docs/app/templates/public-pages/docs/migrate-8-0-to-9-0.gts index 166ec368..87ce1a9d 100644 --- a/docs/app/templates/public-pages/docs/migrate-8-0-to-9-0.gts +++ b/docs/app/templates/public-pages/docs/migrate-8-0-to-9-0.gts @@ -41,6 +41,17 @@ import { LinkTo } from '@ember/routing'; sass-embedded.

+
  • +

    + The + dropdown + option has been removed from + calculatePosition. Previously, this option passed the + current class instance to + calculatePosition.
    + Note: This option was never documented. +

    +
  • Passing diff --git a/ember-basic-dropdown/src/components/basic-dropdown.gts b/ember-basic-dropdown/src/components/basic-dropdown.gts index f1af9c80..33972970 100644 --- a/ember-basic-dropdown/src/components/basic-dropdown.gts +++ b/ember-basic-dropdown/src/components/basic-dropdown.gts @@ -306,7 +306,6 @@ export default class BasicDropdown extends Component { previousVerticalPosition, renderInPlace, matchTriggerWidth, - dropdown: this, }, ); return this.applyReposition(triggerElement, dropdownElement, positionData); diff --git a/ember-basic-dropdown/src/utils/calculate-position.ts b/ember-basic-dropdown/src/utils/calculate-position.ts index ca591764..238843d6 100644 --- a/ember-basic-dropdown/src/utils/calculate-position.ts +++ b/ember-basic-dropdown/src/utils/calculate-position.ts @@ -1,4 +1,3 @@ -import type BasicDropdown from '../components/basic-dropdown.gts'; import type { VerticalPosition, HorizontalPosition } from '../types.ts'; // To avoid breaking the current types export we need this @@ -11,7 +10,6 @@ export interface CalculatePositionOptions { previousHorizontalPosition?: HorizontalPosition | undefined; previousVerticalPosition?: VerticalPosition | undefined; renderInPlace: boolean; - dropdown: BasicDropdown; } export type CalculatePositionResultStyle = { diff --git a/test-app/tests/integration/components/basic-dropdown-test.gts b/test-app/tests/integration/components/basic-dropdown-test.gts index cafc2cb9..caf3add5 100644 --- a/test-app/tests/integration/components/basic-dropdown-test.gts +++ b/test-app/tests/integration/components/basic-dropdown-test.gts @@ -1057,13 +1057,8 @@ module('Integration | Component | basic-dropdown', function (hooks) { const self = this; assert.expect(4); - this.calculatePosition = function ( - _triggerElement, - _dropdownElement, - _destinationElement, - { dropdown }, - ) { - assert.ok(dropdown, 'dropdown should be passed to the component'); + this.calculatePosition = function () { + assert.ok('custom calculatePosition was passed to the component'); return { horizontalPosition: 'right', verticalPosition: 'above', @@ -1118,9 +1113,12 @@ module('Integration | Component | basic-dropdown', function (hooks) { _triggerElement, _dropdownElement, _destinationElement, - { dropdown, renderInPlace }, + { renderInPlace }, ) { - assert.ok(dropdown, 'dropdown should be passed to the component'); + assert.ok( + renderInPlace, + 'custom calculatePosition with renderInPlace was passed to the component', + ); if (renderInPlace) { return { horizontalPosition: 'right',