Skip to content

Add @triggerHtmlTag in docs and add notes to migrate to v9.x #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkszepp merged 1 commit into from
Dec 13, 2025
Merged

Add @triggerHtmlTag in docs and add notes to migrate to v9.x #1034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion docs/app/templates/public-pages/docs/api-reference.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ import { LinkTo } from '@ember/routing';
<td>The component to render as trigger instead of the default trigger
component.</td>
</tr>
<tr>
<td>triggerHtmlTag</td>
<td><code>String</code></td>
<td>(Default: <code>'div'</code>) The tag of the trigger component</td>
</tr>
<tr>
<td>verticalPosition</td>
<td><code>String</code></td>
Expand Down Expand Up @@ -209,7 +214,10 @@ import { LinkTo } from '@ember/routing';
<tr>
<td>htmlTag</td>
<td>String</td>
<td>(Default: <code>'div'</code>) The tag of the trigger component</td>
<td>(Default:
<code>'div'</code>) The tag of the trigger component (Note: If you are
using the yielded trigger component, please use
<code>@triggerHtmlTag</code>)</td>
</tr>
<tr>
<td>title</td>
Expand Down
26 changes: 19 additions & 7 deletions docs/app/templates/public-pages/docs/migrate-8-0-to-9-0.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ import { LinkTo } from '@ember/routing';
</li>
<li>
<p>
Passing
<code>@dropdownId</code>
wasn't working correctly without using custom modifiers and was
undocumented. Remove this parameter and use the
<code>uniqueId</code>
property from the public API instead.
If you are using
<code>@htmlTag</code>
on the yielded trigger component (for example,
<code>&lt;dd.Trigger @htmlTag="span"&gt;</code>) replace it with
<code>&lt;BasicDropdown @triggerHtmlTag="span"&gt;</code>
This change is required to fix Glint v2 typing issues.
<br />
<small><i>(Deprecation added in 8.8)</i></small>
<small><i>(Deprecation added in 8.10)</i></small>
</p>
</li>
<li>
Expand Down Expand Up @@ -91,6 +91,18 @@ import { LinkTo } from '@ember/routing';
<small><i>(Deprecation added in 8.9)</i></small>
</p>
</li>
<li>
<p>
Passing
<code>@dropdownId</code>
wasn't working correctly without using custom modifiers and was
undocumented. Remove this parameter and use the
<code>uniqueId</code>
property from the public API instead.
<br />
<small><i>(Deprecation added in 8.8)</i></small>
</p>
</li>
</ul>

<div class="doc-page-nav">
Expand Down