Skip to content

Remove parameter @dir on content component #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkszepp merged 2 commits into from
Dec 13, 2025
+8 −3
Merged

Remove parameter @dir on content component #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0eae7d
Remove option to pass parameter `@dir` to BasicDropdownContent
mkszepp Dec 13, 2025
e61b595
Add change in docs
mkszepp Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/app/templates/public-pages/docs/migrate-8-0-to-9-0.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ import { LinkTo } from '@ember/routing';
Note: This option was never documented.
</p>
</li>
<li>
<p>
Passing
<code>@dir</code>
to the content component has been removed. Please pass this parameter as
a regular HTML attribute instead.
</p>
</li>
<li>
<p>
If you are using
Expand Down
3 changes: 0 additions & 3 deletions ember-basic-dropdown/src/components/basic-dropdown-content.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ export interface BasicDropdownContentSignature {
otherStyles?: Record<string, string | number | undefined>;
hPosition?: HorizontalPosition | null;
vPosition?: VerticalPosition | null;
dir?: string;
defaultClass?: string;
overlay?: boolean;
htmlTag?: keyof HTMLElementTagNameMap;
Expand Down Expand Up @@ -554,7 +553,6 @@ export default class BasicDropdownContent extends Component<BasicDropdownContent
' ember-basic-dropdown-content--in-place'
}}
{{@defaultClass}}"
dir={{@dir}}
...attributes
{{style @otherStyles this.positionStyles}}
{{this.respondToEvents}}
Expand Down Expand Up @@ -586,7 +584,6 @@ export default class BasicDropdownContent extends Component<BasicDropdownContent
' ember-basic-dropdown-content--in-place'
}}
{{@defaultClass}}"
dir={{@dir}}
...attributes
{{style @otherStyles this.positionStyles}}
{{this.respondToEvents}}
Expand Down