Skip to content

Add @contentHtmlTag #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkszepp merged 1 commit into from
Dec 14, 2025
Merged

Add @contentHtmlTag #1038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ember-basic-dropdown/src/components/basic-dropdown-content.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export interface BasicDropdownContentSignature {
dir?: string;
defaultClass?: string;
overlay?: boolean;
htmlTag?: keyof HTMLElementTagNameMap;
htmlTag?: keyof HTMLElementTagNameMap | undefined;
onFocusIn?: (dropdown?: Dropdown, event?: FocusEvent) => void;
onFocusOut?: (dropdown?: Dropdown, event?: FocusEvent) => void;
onMouseEnter?: (dropdown?: Dropdown, event?: MouseEvent) => void;
Expand Down
2 changes: 2 additions & 0 deletions ember-basic-dropdown/src/components/basic-dropdown.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export interface BasicDropdownArgs {
preventScroll?: boolean;
matchTriggerWidth?: boolean;
triggerHtmlTag?: keyof HTMLElementTagNameMap;
contentHtmlTag?: keyof HTMLElementTagNameMap;
onInit?: (dropdown: Dropdown) => void;
registerAPI?: (dropdown: Dropdown | null) => void;
onOpen?: (dropdown: Dropdown, e?: Event) => boolean | void;
Expand Down Expand Up @@ -544,6 +545,7 @@ export default class BasicDropdown extends Component<BasicDropdownSignature> {
preventScroll=@preventScroll
rootEventType=(or @rootEventType "click")
vPosition=this.vPosition
htmlTag=@contentHtmlTag
destination=this.destination
destinationElement=this.destinationElement
top=this.top
Expand Down