Skip to content

Implement @verticalPosition="auto" for @renderInPlace={{true}}#1045

Merged
mkszepp merged 5 commits intomasterfrom
implement-verticalPosition-auto-for-render-in-place
Dec 24, 2025
Merged

Implement @verticalPosition="auto" for @renderInPlace={{true}}#1045
mkszepp merged 5 commits intomasterfrom
implement-verticalPosition-auto-for-render-in-place

Conversation

@mkszepp
Copy link
Copy Markdown
Collaborator

@mkszepp mkszepp commented Dec 23, 2025

Suppresses #1016.

Until now, @verticalPosition="auto" was not implemented when using @renderInPlace={{true}}. This behavior was expected and documented:

Please note that when rendering the content in place, the vertical position will not automatically detect the best position based on the space around the trigger. You have to explicitly pass verticalPosition="above" to render it over the trigger.

With this PR, verticalPosition="auto" is now fully supported even when @renderInPlace={{true}}.

Special thanks to @velrest, who initially started this work

@mkszepp mkszepp changed the title Implement @verticalPosition="auto" for @renderInPlace={{true}} Implement @verticalPosition="auto" for @renderInPlace={{true}} Dec 23, 2025
@mkszepp mkszepp merged commit 831fef3 into master Dec 24, 2025
17 checks passed
@mkszepp mkszepp mentioned this pull request Dec 24, 2025
17 tasks
@mkszepp mkszepp deleted the implement-verticalPosition-auto-for-render-in-place branch December 24, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant