Upgrade ember-estree to ^0.6.10#231
Merged
NullVoxPopuli merged 2 commits intoJul 3, 2026
Merged
Conversation
ember-estree < 0.6.10 backslash-escaped backticks and dollar signs when building its same-length placeholder JS. Each escape grew the placeholder by one character, and once the growth exceeded the padding slack (11 chars for class-member templates) the placeholder no longer matched the original <template> region: the raw static block leaked into the AST and no-unused-expressions fired on it, with all offsets after the template shifted. Fixed upstream in NullVoxPopuli/ember-estree#69 by blanking the characters instead of escaping. Adds an end-to-end regression test with the exact snippet from ember-tooling#230. The refreshed lockfile pulls newer oxc-parser/content-tag within ember-estree's ranges, which rewords one syntax-error diagnostic; the inline snapshot is updated to match. Fixes ember-tooling#230 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ember-estree 0.6.10 requires content-tag ^4.2.0, whose newer swc rewords
the parse diagnostic ("× Unexpected eof" → "× Expected ',', got '<eof>'")
and shifts the reported column by one.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NullVoxPopuli
approved these changes
Jul 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230
What
Bumps
ember-estreefrom^0.6.3to^0.6.10, which includes NullVoxPopuli/ember-estree#69.Why
ember-estree < 0.6.10 backslash-escaped
`and$when building its same-length placeholder JS for<template>regions. Each escape grew the placeholder by one character, and once the growth exceeded the padding slack (11 chars for class-member templates, 19 for expression templates) the placeholder no longer lined up with the original region. The range match failed silently, the rawstatic{...}placeholder leaked into the final AST — which is what@typescript-eslint/no-unused-expressionsflagged in #230 — and every offset after the template shifted.The #230 snippet has exactly 12 backticks across its two comments, one over the class-member limit. This was the same root cause as #226, which was fixed in this repo's own
transformForLintcopy of the placeholder logic (1e7c572); the ember-estree copy had no length guard, so it failed silently instead of loudly.Changes
ember-estree^0.6.3→^0.6.10Linterpass withno-unused-expressionson the exact snippet fromtypescript-eslinterror on a file #230× Unexpected eof→× Expected ',', got '<eof>')🤖 Generated with Claude Code