Modernize ESLint configuration (#2759)

Author: mansona

packages/ember-inspector/.npmignore

@@ -1,23 +1,8 @@
-node_modules/
-tmp/
-.DS_Store
-*.swp
-
-dist/**/*.zip
-dist/testing
-
-dist_prev
-
-*.xpi
-
-.mozilla-addon-sdk
-
-aws.json
-config/secrets.json
-
-# ember-try
-.node_modules.ember-try/
-bower.json.ember-try
-package.json.ember-try
-
-.idea/
+# Development tooling — not needed in the published package
+babel.config.js
+ember-cli-build.js
+eslint.config.mjs
+gulpfile.js
+testem.js
+scripts/
+tests/

packages/ember-inspector/app/components/list.js

@@ -1,8 +1,10 @@
+/* global basicContext */
+
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 import { localCopy } from 'tracked-toolbox';
 import { bind, scheduleOnce } from '@ember/runloop';
-import { restartableTask, timeout } from 'ember-concurrency';
+import { task, timeout } from 'ember-concurrency';
 import ResizableColumns from 'ember-inspector/libs/resizable-columns';
 import { inject as service } from '@ember/service';
 import { action } from '@ember/object';
@@ -199,11 +201,10 @@ export default class ListComponent extends Component {
    * @property debounceColumnWidths
    * @type {Object} Ember Concurrency task
    */
-  @restartableTask
-  *debounceColumnWidths() {
-    yield timeout(100);
+  debounceColumnWidths = task({ restartable: true }, async () => {
+    await timeout(100);
     this.resizableColumns.setTableWidth(this.getTableWidth());
-  }
+  });
 
   /**
    * Hook called when the component element will be destroyed.

packages/ember-inspector/app/components/object-inspector/properties-all.js

@@ -28,7 +28,10 @@ export default class PropertiesAll extends PropertiesBase {
           ? p.name.toLowerCase().indexOf(this.args.customFilter.toLowerCase()) >
             -1
           : true;
-        return !p.hasOwnProperty('overridden') && shouldApplyCustomFilter;
+        return (
+          !Object.prototype.hasOwnProperty.call(p, 'overridden') &&
+          shouldApplyCustomFilter
+        );
       }, this);
     }, this);
 

packages/ember-inspector/app/controllers/route-tree.js

@@ -7,6 +7,9 @@ import { inject as service } from '@ember/service';
 import checkCurrentRoute from 'ember-inspector/utils/check-current-route';
 import searchMatch from 'ember-inspector/utils/search-match';
 import isRouteSubstate from 'ember-inspector/utils/is-route-substate';
+import RouteCellName from 'ember-inspector/components/route-cell-name';
+import RouteCellObjects from 'ember-inspector/components/route-cell-objects';
+import RouteCellUrl from 'ember-inspector/components/route-cell-url';
 
 export default class RouteTreeController extends Controller {
   @controller application;
@@ -18,6 +21,12 @@ export default class RouteTreeController extends Controller {
 
   searchValue = '';
 
+  routeCells = {
+    name: RouteCellName,
+    objects: RouteCellObjects,
+    url: RouteCellUrl,
+  };
+
   @alias('options.hideRoutes') hideRoutes;
 
   @computed(

packages/ember-inspector/app/services/adapters/basic.js

@@ -74,14 +74,14 @@ export default class Basic extends Service {
    *
    * @param _neededVersion (The version to go to)
    */
-  onVersionMismatch(_neededVersion) {}
+  onVersionMismatch(/* _neededVersion */) {}
 
   /**
     Used to send messages to EmberDebug
 
     @param _message the message to send
   **/
-  sendMessage(_message) {}
+  sendMessage(/* _message */) {}
 
   /**
     Register functions to be called
@@ -99,7 +99,8 @@ export default class Basic extends Service {
 
   // Called when the "Reload" is clicked by the user
   willReload() {}
-  openResource(_file, _line) {}
+
+  openResource(/* _file, _line */) {}
 
   @action
   refreshPage() {

packages/ember-inspector/app/services/adapters/chrome.js

@@ -1,3 +1,5 @@
+/* global chrome */
+
 import WebExtension from './web-extension';
 import { tracked } from '@glimmer/tracking';
 

packages/ember-inspector/app/services/adapters/web-extension.js

@@ -1,3 +1,5 @@
+/* global chrome */
+
 import { tracked } from '@glimmer/tracking';
 
 import BasicAdapter from './basic';

packages/ember-inspector/app/templates/route-tree.hbs

@@ -26,9 +26,7 @@
       }} as |r|
     >
       <r.cell as |route|>
-        {{#let
-          (component (concat "route-cell-" r.columnValue.valuePath)) as |Cell|
-        }}
+        {{#let (get this.routeCells r.columnValue.valuePath) as |Cell|}}
           <Cell
             @route={{route}}
             @currentRoute={{this.currentRoute}}

packages/ember-inspector/babel.config.js

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 module.exports = {
   plugins: [
     [

packages/ember-inspector/config/ember-try.js

@@ -1,3 +1,5 @@
+/* eslint-disable n/no-unpublished-require */
+
 'use strict';
 
 const getChannelURL = require('ember-source-channel-url');