Skip to content

Commit c6afd41

Browse files
authored
Use import for compareVersions (#2758)
2 parents 1802920 + 487830c commit c6afd41

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

packages/ember-inspector/app/routes/launch.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import Route from '@ember/routing/route';
55
import RSVP from 'rsvp';
66
const { Promise } = RSVP;
77
import { LOCAL_STORAGE_SUPPORTED } from 'ember-inspector/services/storage/local';
8+
import { compareVersions } from 'compare-versions';
89

910
const chromeStoreSupported = !!window.chrome && !!window.chrome.storage;
1011
const storageSupported = chromeStoreSupported || LOCAL_STORAGE_SUPPORTED;
@@ -25,7 +26,7 @@ export default class LaunchRoute extends Route {
2526
this.setLastVersionOpened(currentVersion);
2627
if (
2728
storageSupported &&
28-
window.compareVersions(currentVersion, lastVersion) > 0
29+
compareVersions(currentVersion, lastVersion) > 0
2930
) {
3031
targetRoute = 'whats-new';
3132
}

packages/ember-inspector/ember-cli-build.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ module.exports = function (defaults) {
8787
app.import('node_modules/basiccontext/dist/basicContext.min.css');
8888
app.import('node_modules/basiccontext/dist/themes/default.min.css');
8989
app.import('node_modules/basiccontext/dist/basicContext.min.js');
90-
app.import('node_modules/compare-versions/index.js');
9190
app.import('node_modules/normalize.css/normalize.css');
9291

9392
const previousEmberVersionsSupportedString = JSON.stringify(

packages/ember-inspector/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"broccoli-stew": "^3.0.0",
6666
"broccoli-string-replace": "^0.1.2",
6767
"codeclimate-test-reporter": "^0.5.1",
68-
"compare-versions": "^4.1.4",
68+
"compare-versions": "^6.1.1",
6969
"del": "^6.1.1",
7070
"ember-auto-import": "^2.10.0",
7171
"ember-cli": "~6.1.0",

pnpm-lock.yaml

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)