Update ESLint configuration

Author: pichfl

packages/ember-inspector/.npmignore

@@ -1,23 +1,8 @@
-node_modules/
-tmp/
-.DS_Store
-*.swp
-
-dist/**/*.zip
-dist/testing
-
-dist_prev
-
-*.xpi
-
-.mozilla-addon-sdk
-
-aws.json
-config/secrets.json
-
-# ember-try
-.node_modules.ember-try/
-bower.json.ember-try
-package.json.ember-try
-
-.idea/
+# Development tooling — not needed in the published package
+babel.config.js
+ember-cli-build.js
+eslint.config.mjs
+gulpfile.js
+testem.js
+scripts/
+tests/

packages/ember-inspector/app/components/list.js

@@ -1,3 +1,5 @@
+/* global basicContext */
+
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 import { localCopy } from 'tracked-toolbox';
@@ -199,11 +201,10 @@ export default class ListComponent extends Component {
    * @property debounceColumnWidths
    * @type {Object} Ember Concurrency task
    */
-  // @task({restartable: true})
-  debounceColumnWidths = task({restartable: true} , async () => {
+  debounceColumnWidths = task({ restartable: true }, async () => {
     await timeout(100);
     this.resizableColumns.setTableWidth(this.getTableWidth());
-  })
+  });
 
   /**
    * Hook called when the component element will be destroyed.

packages/ember-inspector/app/components/object-inspector/properties-all.js

@@ -28,7 +28,10 @@ export default class PropertiesAll extends PropertiesBase {
           ? p.name.toLowerCase().indexOf(this.args.customFilter.toLowerCase()) >
             -1
           : true;
-        return !p.hasOwnProperty('overridden') && shouldApplyCustomFilter;
+        return (
+          !Object.prototype.hasOwnProperty.call(p, 'overridden') &&
+          shouldApplyCustomFilter
+        );
       }, this);
     }, this);
 

packages/ember-inspector/app/services/adapters/basic.js

@@ -74,14 +74,14 @@ export default class Basic extends Service {
    *
    * @param _neededVersion (The version to go to)
    */
-  onVersionMismatch(_neededVersion) {}
+  onVersionMismatch(/* _neededVersion */) {}
 
   /**
     Used to send messages to EmberDebug
 
     @param _message the message to send
   **/
-  sendMessage(_message) {}
+  sendMessage(/* _message */) {}
 
   /**
     Register functions to be called
@@ -99,7 +99,8 @@ export default class Basic extends Service {
 
   // Called when the "Reload" is clicked by the user
   willReload() {}
-  openResource(_file, _line) {}
+
+  openResource(/* _file, _line */) {}
 
   @action
   refreshPage() {

packages/ember-inspector/app/services/adapters/chrome.js

@@ -1,3 +1,5 @@
+/* global chrome */
+
 import WebExtension from './web-extension';
 import { tracked } from '@glimmer/tracking';
 

packages/ember-inspector/app/services/adapters/web-extension.js

@@ -1,3 +1,5 @@
+/* global chrome */
+
 import { tracked } from '@glimmer/tracking';
 
 import BasicAdapter from './basic';

packages/ember-inspector/babel.config.js

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 module.exports = {
   plugins: [
     [

packages/ember-inspector/config/ember-try.js

@@ -1,3 +1,5 @@
+/* eslint-disable n/no-unpublished-require */
+
 'use strict';
 
 const getChannelURL = require('ember-source-channel-url');

packages/ember-inspector/ember-cli-build.js

@@ -1,5 +1,6 @@
-'use strict';
+/* eslint-disable no-undef */
 
+'use strict';
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');
 const VersionChecker = require('ember-cli-version-checker');
 const mergeTrees = require('broccoli-merge-trees');

packages/ember-inspector/eslint.config.mjs

@@ -14,53 +14,33 @@
  */
 import globals from 'globals';
 import js from '@eslint/js';
+import { defineConfig, globalIgnores } from 'eslint/config';
 
 import ember from 'eslint-plugin-ember/recommended';
-
-import prettierConfig from 'eslint-config-prettier';
+import eslintConfigPrettier from 'eslint-config-prettier';
 import qunit from 'eslint-plugin-qunit';
 import n from 'eslint-plugin-n';
 
-import babelParser from '@babel/eslint-parser';
+import babelParser from '@babel/eslint-parser/experimental-worker';
 
-const parserOptions = {
-  esm: {
-    js: {
-      ecmaFeatures: { modules: true },
-      ecmaVersion: 'latest',
-      requireConfigFile: false,
-      babelOptions: {
-        plugins: [
-          [
-            '@babel/plugin-proposal-decorators',
-            { decoratorsBeforeExport: true },
-          ],
-        ],
-      },
-    },
-  },
+const esmParserOptions = {
+  ecmaFeatures: { modules: true },
+  ecmaVersion: 'latest',
 };
 
-export default [
+export default defineConfig([
+  globalIgnores([
+    'dist/',
+    'dist_prev/',
+    'vendor/',
+    'coverage/',
+    'skeletons/',
+    '!**/.*',
+  ]),
   js.configs.recommended,
+  eslintConfigPrettier,
   ember.configs.base,
   ember.configs.gjs,
-  prettierConfig,
-  /**
-   * Ignores must be in their own object
-   * https://eslint.org/docs/latest/use/configure/ignore
-   */
-  {
-    ignores: [
-      'dist/',
-      'node_modules/',
-      'coverage/',
-      '!**/.*',
-      'vendor/',
-      'dist_prev/',
-      'skeletons/',
-    ],
-  },
   /**
    * https://eslint.org/docs/latest/use/configure/configuration-files#configuring-linter-options
    */
@@ -69,33 +49,26 @@ export default [
       reportUnusedDisableDirectives: 'error',
     },
   },
-  {
-    rules: {
-      'no-prototype-builtins': 'off',
-      'no-useless-escape': 'off',
-      'no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
-    },
-  },
   {
     files: ['**/*.js'],
     languageOptions: {
       parser: babelParser,
     },
+    rules: {
+      'no-useless-escape': 'off',
+    },
   },
   {
     files: ['**/*.{js,gjs}'],
     languageOptions: {
-      parserOptions: parserOptions.esm.js,
+      parserOptions: esmParserOptions,
       globals: {
         ...globals.browser,
-        basicContext: false,
-        requireModule: false,
-        globalThis: true,
-        chrome: 'readonly',
       },
     },
   },
   {
+    ...qunit.configs.recommended,
     files: ['tests/**/*-test.{js,gjs}'],
     plugins: {
       qunit,
@@ -105,19 +78,16 @@ export default [
    * CJS node files
    */
   {
+    ...n.configs['flat/recommended-script'],
     files: [
       '**/*.cjs',
-      'config/**/*.js',
-      'lib/*/index.js',
-      'scripts/**/*.js',
-      'testem.js',
-      'testem*.js',
       '.prettierrc.js',
       '.stylelintrc.js',
       '.template-lintrc.js',
       'babel.config.js',
-      'ember-cli-build.js',
-      'gulpfile.js',
+      'config/**/*.js',
+      'scripts/download-panes.js',
+      'testem.js',
     ],
     plugins: {
       n,
@@ -128,15 +98,14 @@ export default [
       ecmaVersion: 'latest',
       globals: {
         ...globals.node,
-        basicContext: false,
-        requireModule: false,
       },
     },
   },
   /**
    * ESM node files
    */
   {
+    ...n.configs['flat/recommended-module'],
     files: ['**/*.mjs'],
     plugins: {
       n,
@@ -145,12 +114,22 @@ export default [
     languageOptions: {
       sourceType: 'module',
       ecmaVersion: 'latest',
-      parserOptions: parserOptions.esm.js,
+      parserOptions: esmParserOptions,
+      globals: {
+        ...globals.node,
+      },
+    },
+  },
+  /**
+   * Gulp files
+   */
+  {
+    files: ['gulpfile.js'],
+    languageOptions: {
       globals: {
         ...globals.node,
-        basicContext: false,
-        requireModule: false,
+        gulp: 'readonly',
       },
     },
   },
-];
+]);