Skip to content

Commit f8ecb1b

Browse files
committed
fix: eagerly failing on missing 'require'
1 parent f9b969d commit f8ecb1b

3 files changed

Lines changed: 4 additions & 17 deletions

File tree

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ OR:
1414
- Clone the repository
1515
- cd into the repo directory
1616
- run `pnpm install`
17-
- run `pnpm build` to build the `packages/build/dist` directory
17+
- run `pnpm build:production` to build the `packages/build/dist` directory
1818
- Visit `chrome://extensions` in Chrome
1919
- Make sure `Developer mode` is checked
2020
- Click on 'Load unpacked extension...'
@@ -30,7 +30,7 @@ OR:
3030
- Clone the repository
3131
- cd into the repo directory
3232
- run `pnpm install`
33-
- run `pnpm build` to build the `packages/build/dist` directory
33+
- run `pnpm build:production` to build the `packages/build/dist` directory
3434
- Visit `about:debugging#/runtime/this-firefox` in Firefox
3535
- Click on 'Load Temporary Add-on…'
3636
- Choose the `packages/build/dist/firefox/manifest.json` file in the cloned repo
@@ -40,7 +40,7 @@ OR:
4040
- Clone the repository
4141
- cd into the repo directory
4242
- run `pnpm install`
43-
- run `pnpm build` to build the `packages/build/dist` directory
43+
- run `pnpm build:production` to build the `packages/build/dist` directory
4444
- Visit `chrome://extensions` in Opera
4545
- Make sure `Developer mode` is checked
4646
- Click on 'Load unpacked extension...'

packages/ember-inspector/config/environment.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ module.exports = function (environment) {
3636
if (environment === 'test') {
3737
// Testem prefers this...
3838
ENV.locationType = 'none';
39+
ENV.rootURL = '/';
3940

4041
// keep test console output quieter
4142
ENV.APP.LOG_ACTIVE_GENERATION = false;

packages/ember-inspector/ember-cli-build.js

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -52,20 +52,6 @@ module.exports = function (defaults) {
5252
],
5353
});
5454

55-
if (process.env.EMBER_ENV === 'test') {
56-
// `ember test` expects the index.html file to be in the output directory.
57-
return replace(tree, {
58-
files: ['tests/index.html'],
59-
patterns: [
60-
// Change base tag for running tests in development env.
61-
{
62-
match: /<base.*\/>/,
63-
replacement: '',
64-
},
65-
],
66-
});
67-
}
68-
6955
if (
7056
process.env.EMBER_ENV === 'test' ||
7157
process.env.EMBER_ENV === 'development'

0 commit comments

Comments
 (0)