Skip to content

fix tab action icon detection of newer ember apps #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobbieTheWagner merged 2 commits into from
Mar 25, 2026
Merged

fix tab action icon detection of newer ember apps #2736

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9590d14
fix tab action icon detection of newer ember apps
patricklx Mar 24, 2026
33cb334
cleanup
patricklx Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion skeletons/web-extension/scripts/in-page-script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,20 @@
}
}

onReady(function () {
onReady(async function () {
let Ember;
try {
Ember = requireModule('ember')['default'];
} catch {
Ember = window.Ember;
}
var libraries = Ember && Ember.libraries;
if (globalThis.emberInspectorApps) {
const appLoader = globalThis.emberInspectorApps[0];
const internalEmberModules = await appLoader.loadCompatInspector();
const InternalsMetal = internalEmberModules.InternalsMetal;
libraries = InternalsMetal?.libraries;
}
if (libraries) {
// Ember has changed where the array of libraries is located.
// In older versions, `Ember.libraries` was the array itself,
Expand Down
Loading