Security: Untrusted link opening can enable reverse-tabnabbing and script-scheme execution#2738
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The click handler opens any anchor `href` via `window.open(e.target.href)` without `noopener/noreferrer` protections and without validating URL schemes. If a malicious link is rendered (e.g., `javascript:` or attacker-controlled external URL), this can lead to opener manipulation (reverse tabnabbing) or unsafe navigation behavior. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Untrusted link opening can enable reverse-tabnabbing and script-scheme execution
Problem
Severity:
Medium| File:app/components/ui/open-links-in-new-window.js:L5The click handler opens any anchor
hrefviawindow.open(e.target.href)withoutnoopener/noreferrerprotections and without validating URL schemes. If a malicious link is rendered (e.g.,javascript:or attacker-controlled external URL), this can lead to opener manipulation (reverse tabnabbing) or unsafe navigation behavior.Solution
Validate the URL before opening (allow only
http:/https:as needed), and open withnoopener,noreferrer(e.g.,window.open(url, '_blank', 'noopener,noreferrer')). Also consider resolving the nearest<a>viaclosest('a')and rejecting missing/invalid hrefs.Changes
app/components/ui/open-links-in-new-window.js(modified)