Drop support for websocket adapter#2760
Merged
Merged
Conversation
This transport is not covered by tests. 11 years ago there was a separate addon, which relied on this https://github.com/joostdevries/ember-cli-remote-inspector/blob/b1d4d99105e1e052ebdf472c951a5f11b83ed55f/addon/debug-server.js#L29 Today, most browsers support remote debugging using built-in DevTools and we want to consolidate the communication works across Ember Inspector and Ember Debug.
mansona
approved these changes
May 27, 2026
mansona
left a comment
mansona
left a comment
Member
There was a problem hiding this comment.
I'm pretty sure this can't be used in the current state, and it's likely broken because it is not tested. I'm going to mark this as breaking because technically it is breaking but I suspect we're going to do a major release once we move things to vite 👍
Collaborator
|
ember-tui and ember-native both depend on web socket adapter |
Collaborator
|
I wonder if ember electron also used it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This transport is not covered by tests. 11 years ago there was a separate addon, which relied on this https://github.com/joostdevries/ember-cli-remote-inspector/blob/b1d4d99105e1e052ebdf472c951a5f11b83ed55f/addon/debug-server.js#L29
Today, most browsers support remote debugging using built-in DevTools and we want to consolidate the communication works across Ember Inspector and Ember Debug.