Modernize SCSS setup#2764
Open
pichfl wants to merge 1 commit into
Open
Conversation
- Convert @import to meta.load-css to resolve warnings - Convert most of the SCSS code to plain CSS to make remove SASS easier
evoactivity
suggested changes
Jul 1, 2026
| "left" $nav-main-item-height - 6px | ||
| "right" $nav-main-item-height - 6px; | ||
| "left" calc(var(--nav-main-item-height) - 6px) | ||
| "right" var(--nav-main-item-height) - 6px; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove reliance on SCSS/SASS, replacing SCSS variables with native custom properties.
This should make it easier to drop SCSS and move to plain modern CSS and simpler bundling once we move the build chain to Vite.
This also moves importing the
normalize.csspackage from ember-cli-build.js straight into SCSS, slowly chipping away at the vendor imports.