Remove assert.expect calls

This is no longer recommended and is a linting violation. Removed them.

Author: jrjohnson

tests/integration/modifiers/did-insert-test.js

@@ -13,8 +13,6 @@ module('Integration | Modifier | did-insert', function (hooks) {
   setupRenderingTest(hooks);
 
   test('it basically works', async function (assert) {
-    assert.expect(2);
-
     this.someMethod = (element) => {
       assert.strictEqual(element.tagName, 'DIV', 'correct element tagName');
       assert.dom(element).hasAttribute('data-foo', 'some-thing');
@@ -25,8 +23,6 @@ module('Integration | Modifier | did-insert', function (hooks) {
   });
 
   test('it can accept arguments', async function (assert) {
-    assert.expect(4);
-
     this.someMethod = (element, positional, named) => {
       assert.strictEqual(element.tagName, 'DIV', 'correct element tagName');
       assert.dom(element).hasAttribute('data-foo', 'some-thing');
@@ -45,8 +41,6 @@ module('Integration | Modifier | did-insert', function (hooks) {
   });
 
   test('it is not invoked again when arguments change', async function (assert) {
-    assert.expect(4);
-
     this.someMethod = (element, positional, named) => {
       assert.strictEqual(element.tagName, 'DIV', 'correct element tagName');
       assert.dom(element).hasAttribute('data-foo', 'some-thing');

tests/integration/modifiers/did-update-test.js

@@ -10,8 +10,6 @@ module('Integration | Modifier | did-update', function (hooks) {
   setupRenderingTest(hooks);
 
   test('it basically works', async function (assert) {
-    assert.expect(4);
-
     this.someMethod = (element, positional, named) => {
       assert.strictEqual(element.tagName, 'DIV', 'correct element tagName');
       assert.dom(element).hasAttribute('data-foo', 'some-thing');
@@ -31,8 +29,6 @@ module('Integration | Modifier | did-update', function (hooks) {
   // only run the next test where @tracked is present
   if (macroCondition(dependencySatisfies('ember-source', '>= 3.12.0'))) {
     test('it consumes tracked properties without re-invoking', async function (assert) {
-      assert.expect(1);
-
       class Context {
         @tracked boundValue = 'initial';
         @tracked secondaryValue = 'initial';

tests/integration/modifiers/will-destroy-test.js

@@ -7,8 +7,6 @@ module('Integration | Modifier | will-destroy', function (hooks) {
   setupRenderingTest(hooks);
 
   test('it basically works', async function (assert) {
-    assert.expect(2);
-
     this.someMethod = (element) => {
       assert.strictEqual(element.tagName, 'DIV', 'correct element tagName');
       assert.dom(element).hasAttribute('data-foo', 'some-thing');
@@ -24,8 +22,6 @@ module('Integration | Modifier | will-destroy', function (hooks) {
   });
 
   test('it can accept arguments', async function (assert) {
-    assert.expect(4);
-
     this.someMethod = (element, positional, named) => {
       assert.strictEqual(element.tagName, 'DIV', 'correct element tagName');
       assert.dom(element).hasAttribute('data-foo', 'some-thing');