From 38bd283312bff675dd28986f30ea97582bc349e4 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Wed, 1 Oct 2025 17:41:01 -0400 Subject: [PATCH 1/6] Emit fewer modules to optimize vite --- addon/rollup.config.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addon/rollup.config.mjs b/addon/rollup.config.mjs index b870afc57..a6a7aa60b 100644 --- a/addon/rollup.config.mjs +++ b/addon/rollup.config.mjs @@ -22,7 +22,7 @@ export default { // up your addon's public API. Also make sure your package.json#exports // is aligned to the config here. // See https://github.com/embroider-build/embroider/blob/main/docs/v2-faq.md#how-can-i-define-the-public-exports-of-my-addon - addon.publicEntrypoints(['**/*.js', 'index.js', 'template-registry.js']), + addon.publicEntrypoints(['index.js']), // These are the modules that should get reexported into the traditional // "app" tree. Things in here should also be in publicEntrypoints above, but From 837852c43c76a1a4e784721f50dc2172ee665251 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Wed, 1 Oct 2025 17:42:17 -0400 Subject: [PATCH 2/6] Cleanup --- addon/rollup.config.mjs | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/addon/rollup.config.mjs b/addon/rollup.config.mjs index a6a7aa60b..a7ce6368f 100644 --- a/addon/rollup.config.mjs +++ b/addon/rollup.config.mjs @@ -24,16 +24,6 @@ export default { // See https://github.com/embroider-build/embroider/blob/main/docs/v2-faq.md#how-can-i-define-the-public-exports-of-my-addon addon.publicEntrypoints(['index.js']), - // These are the modules that should get reexported into the traditional - // "app" tree. Things in here should also be in publicEntrypoints above, but - // not everything in publicEntrypoints necessarily needs to go here. - addon.appReexports([ - 'components/**/*.js', - 'helpers/**/*.js', - 'modifiers/**/*.js', - 'services/**/*.js', - ]), - // Follow the V2 Addon rules about dependencies. Your code can import from // `dependencies` and `peerDependencies` as well as standard Ember-provided // package names. From 627ed61df4a73116dd55685bf4cbfdd72bc4ddef Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Wed, 1 Oct 2025 17:48:27 -0400 Subject: [PATCH 3/6] Grr tests --- addon/rollup.config.mjs | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/addon/rollup.config.mjs b/addon/rollup.config.mjs index a7ce6368f..960a5c6b2 100644 --- a/addon/rollup.config.mjs +++ b/addon/rollup.config.mjs @@ -22,7 +22,18 @@ export default { // up your addon's public API. Also make sure your package.json#exports // is aligned to the config here. // See https://github.com/embroider-build/embroider/blob/main/docs/v2-faq.md#how-can-i-define-the-public-exports-of-my-addon - addon.publicEntrypoints(['index.js']), + addon.publicEntrypoints([ + 'index.js', + // Included for legacy reasons + 'has-ember-version.js', + // included because this repo doesn't yet use the new source-testing approach + // present in @ember/addon-blueprint + // + // We can delete these entries when we update the blueprint + '-internal/is-promise', + '-internal/debug-info-helpers', + '-internal/test-metadata', + ]), // Follow the V2 Addon rules about dependencies. Your code can import from // `dependencies` and `peerDependencies` as well as standard Ember-provided From 59a650d9b5c1060ea3850bc2ce3a238318e536a4 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Wed, 1 Oct 2025 17:49:31 -0400 Subject: [PATCH 4/6] ope --- addon/rollup.config.mjs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/addon/rollup.config.mjs b/addon/rollup.config.mjs index 960a5c6b2..383061570 100644 --- a/addon/rollup.config.mjs +++ b/addon/rollup.config.mjs @@ -33,6 +33,8 @@ export default { '-internal/is-promise', '-internal/debug-info-helpers', '-internal/test-metadata', + '-internal/warnings', + '-internal/deprecations', ]), // Follow the V2 Addon rules about dependencies. Your code can import from From fec1b0e9644b2bddd711715b67edfb246e20463f Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Wed, 22 Oct 2025 18:00:04 -0400 Subject: [PATCH 5/6] Expose private modules --- addon/rollup.config.mjs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/addon/rollup.config.mjs b/addon/rollup.config.mjs index 383061570..b64e96056 100644 --- a/addon/rollup.config.mjs +++ b/addon/rollup.config.mjs @@ -30,11 +30,14 @@ export default { // present in @ember/addon-blueprint // // We can delete these entries when we update the blueprint - '-internal/is-promise', - '-internal/debug-info-helpers', - '-internal/test-metadata', - '-internal/warnings', - '-internal/deprecations', + '-internal/debug-info.js', + '-internal/debug-info-helpers.js', + '-internal/deprecations.js', + '-internal/is-promise.js', + '-internal/test-metadata.js', + '-internal/warnings.js', + 'dom/-logging.js', + 'settled.js', ]), // Follow the V2 Addon rules about dependencies. Your code can import from From becf27f072ea3fbc9b1688544b7712779151c69f Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Wed, 22 Oct 2025 18:04:07 -0400 Subject: [PATCH 6/6] Expose private modules --- addon/rollup.config.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addon/rollup.config.mjs b/addon/rollup.config.mjs index b64e96056..404a3d6e0 100644 --- a/addon/rollup.config.mjs +++ b/addon/rollup.config.mjs @@ -34,10 +34,10 @@ export default { '-internal/debug-info-helpers.js', '-internal/deprecations.js', '-internal/is-promise.js', - '-internal/test-metadata.js', '-internal/warnings.js', 'dom/-logging.js', 'settled.js', + 'test-metadata.js', ]), // Follow the V2 Addon rules about dependencies. Your code can import from