waitForFocus DOM Helper#1553
Merged
Merged
Conversation
Collaborator
NullVoxPopuli
left a comment
NullVoxPopuli
left a comment
There was a problem hiding this comment.
looks good to me -- want to add docs and all that?
Contributor
Author
|
Will do! |
mogstad
force-pushed
the
push-yvmtvkxoxsun
branch
from
0c84248 to
e1ddf2c
Compare
Convinient helper that resolves when a target receives focus. Useful for verifying keyboard navigation handling and default focus. Uses the pull based waitUntil helper to support the element not being in the DOM when invoking the helper. Alternatives without this helper is asserting `document.activeElement` is the target. It usually work, but there are cases it focus may happne async. The element isn't in view yet.
mogstad
force-pushed
the
push-yvmtvkxoxsun
branch
from
e1ddf2c to
fefae69
Compare
Collaborator
|
I'm going to ignore the types (next) failure on this PR -- it's unrelated to the work here and more about our pre-existing tsconfig. |
|
|
||
| if (!timeoutMessage) { | ||
| const description = getDescription(target); | ||
| timeoutMessage = `waitForFocus timed out waiting for selector "${description}"`; |
Collaborator
There was a problem hiding this comment.
thanks for including the description here!
NullVoxPopuli
approved these changes
Oct 22, 2025
NullVoxPopuli
changed the title
waitForFocus DOM HelperwaitForFocus DOM Helper
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convinient helper that resolves when a target receives focus. Useful for verifying keyboard navigation handling and default focus.
Uses the pull based waitUntil helper to support the element not being in the DOM when invoking the helper.
Alternatives without this helper is asserting
document.activeElementis the target. It usually work, but there are cases it focus may happne async. The element isn't in view yet.