Remove pendingRequests check from ember-testing internal API#1561
Merged
Conversation
…ests Agent-Logs-Url: https://github.com/emberjs/ember-test-helpers/sessions/e3d72001-87b5-4fd2-a672-538f6d115979 Co-authored-by: kategengler <444218+kategengler@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
kategengler
March 28, 2026 01:14
View session
NullVoxPopuli
approved these changes
Mar 28, 2026
Member
|
I have checked and even back in ember-source 4.0.0 this was no longer being incremented or decremented in ember-source, so this is safe to remove in a point release here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
settled.tswas summing request counts from two sources: locally-tracked jQuery AJAX hooks andember-testing/lib/test/pending_requests(a private internal API). This removes the dependency on the latter.Changes
addon/src/settled.ts: Remove import ofpendingRequestsfromember-testing/lib/test/pending_requests; simplifypendingRequests()to return only the local jQuery-tracked request count