refactor: remove private Comparable mixin in favor of duck-type check

Remove the legacy Comparable mixin (Mixin.create) and replace its only
usage in compare() with a local isComparable function that checks
whether compare is a function via duck-typing.

- Delete packages/@ember/-internals/runtime/lib/mixins/comparable.ts
- Delete comparable_test.js
- Remove Comparable export from runtime/index.ts
- Clean up stale references in lib/index.js, package.json, and
  tree-shakability test snapshots
- Add regression test for non-function compare values

Author: olenderhub

lib/index.cjs

@@ -41,7 +41,6 @@ const shim = addonV1Shim(path.join(__dirname, '..'), {
           './dist/dev/packages/@ember/-internals/runtime/index.js',
           './dist/dev/packages/@ember/-internals/runtime/lib/ext/rsvp.js',
           './dist/dev/packages/@ember/-internals/runtime/lib/mixins/-proxy.js',
-          './dist/dev/packages/@ember/-internals/runtime/lib/mixins/comparable.js',
           './dist/dev/packages/@ember/-internals/string/index.js',
           './dist/dev/packages/@ember/-internals/utility-types/index.js',
           './dist/dev/packages/@ember/-internals/utils/index.js',

package.json

@@ -190,7 +190,6 @@
       "@ember/-internals/runtime/lib/ext/rsvp.js": "ember-source/@ember/-internals/runtime/lib/ext/rsvp.js",
       "@ember/-internals/runtime/lib/mixins/-proxy.js": "ember-source/@ember/-internals/runtime/lib/mixins/-proxy.js",
       "@ember/-internals/runtime/lib/mixins/action_handler.js": "ember-source/@ember/-internals/runtime/lib/mixins/action_handler.js",
-      "@ember/-internals/runtime/lib/mixins/comparable.js": "ember-source/@ember/-internals/runtime/lib/mixins/comparable.js",
       "@ember/-internals/runtime/lib/mixins/container_proxy.js": "ember-source/@ember/-internals/runtime/lib/mixins/container_proxy.js",
       "@ember/-internals/runtime/lib/mixins/registry_proxy.js": "ember-source/@ember/-internals/runtime/lib/mixins/registry_proxy.js",
       "@ember/-internals/runtime/lib/mixins/target_action_support.js": "ember-source/@ember/-internals/runtime/lib/mixins/target_action_support.js",

packages/@ember/-internals/runtime/index.ts

@@ -1,6 +1,5 @@
 export { default as RegistryProxyMixin } from './lib/mixins/registry_proxy';
 export { default as ContainerProxyMixin } from './lib/mixins/container_proxy';
-export { default as Comparable } from './lib/mixins/comparable';
 export { default as ActionHandler } from './lib/mixins/action_handler';
 export { default as _ProxyMixin, contentFor as _contentFor } from './lib/mixins/-proxy';
 export { default as MutableEnumerable } from '@ember/enumerable/mutable';

packages/@ember/-internals/runtime/lib/mixins/comparable.ts

@@ -1,6 +1,5 @@
 import type { TypeName } from './type-of';
 import typeOf from './type-of';
-import Comparable from '@ember/-internals/runtime/lib/mixins/comparable';
 import { assert } from '@ember/debug';
 
 const TYPE_ORDER: Record<TypeName, number> = {
@@ -163,10 +162,30 @@ export default function compare<T>(v: T, w: T): Compare {
   }
 }
 
+interface Comparable {
+  compare: (a: unknown, b: unknown) => -1 | 0 | 1;
+}
+
 interface ComparableConstructor {
-  constructor: Comparable;
+  constructor: {
+    compare: (a: unknown, b: unknown) => -1 | 0 | 1;
+  };
 }
 
 function isComparable(value: unknown): value is Comparable & ComparableConstructor {
-  return Comparable.detect(value);
+  if (typeof value !== 'object' || value === null) {
+    return false;
+  }
+
+  let maybeComparable = value as {
+    compare?: unknown;
+    constructor?: {
+      compare?: unknown;
+    };
+  };
+
+  return (
+    typeof maybeComparable.constructor?.compare === 'function' ||
+    typeof maybeComparable.compare === 'function'
+  );
 }

packages/@ember/-internals/runtime/tests/mixins/comparable_test.js

@@ -1,10 +1,9 @@
 import { compare, typeOf } from '@ember/utils';
 import EmberObject from '@ember/object';
-import { Comparable } from '@ember/-internals/runtime';
 import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
 
 let data = [];
-let Comp = EmberObject.extend(Comparable);
+let Comp = EmberObject.extend();
 
 Comp.reopenClass({
   compare(obj) {
@@ -84,5 +83,12 @@ moduleFor(
       assert.equal(compare('b', zero), 0, 'Second item comparable - returns  0 (negated)');
       assert.equal(compare('c', one), -1, 'Second item comparable - returns  1 (negated)');
     }
+
+    ['@test non-function compare does not make an object comparable'](assert) {
+      let obj = EmberObject.create({ compare: null });
+      let other = EmberObject.create({ compare: 'not a function' });
+
+      assert.equal(compare(obj, other), 0, 'objects with non-function compare are not comparable');
+    }
   }
 );

packages/@ember/utils/lib/compare.ts

@@ -115,7 +115,6 @@ it('[dev] has expected tree-shakable entrypoints', async () => {
       "ember-source/@ember/-internals/runtime/lib/ext/rsvp.js",
       "ember-source/@ember/-internals/runtime/lib/mixins/-proxy.js",
       "ember-source/@ember/-internals/runtime/lib/mixins/action_handler.js",
-      "ember-source/@ember/-internals/runtime/lib/mixins/comparable.js",
       "ember-source/@ember/-internals/runtime/lib/mixins/container_proxy.js",
       "ember-source/@ember/-internals/runtime/lib/mixins/registry_proxy.js",
       "ember-source/@ember/-internals/runtime/lib/mixins/target_action_support.js",
@@ -319,7 +318,6 @@ it('[prod] has expected tree-shakable entrypoints', async () => {
       "ember-source/@ember/-internals/runtime/lib/ext/rsvp.js",
       "ember-source/@ember/-internals/runtime/lib/mixins/-proxy.js",
       "ember-source/@ember/-internals/runtime/lib/mixins/action_handler.js",
-      "ember-source/@ember/-internals/runtime/lib/mixins/comparable.js",
       "ember-source/@ember/-internals/runtime/lib/mixins/container_proxy.js",
       "ember-source/@ember/-internals/runtime/lib/mixins/registry_proxy.js",
       "ember-source/@ember/-internals/runtime/lib/mixins/target_action_support.js",