Skip to content

Commit b3564c4

Browse files
committed
[BUGFIX] Include named argument hint in debugger message for class-backed components
1 parent 6d6fafc commit b3564c4

2 files changed

Lines changed: 33 additions & 1 deletion

File tree

  • packages

packages/@glimmer-workspace/integration-tests/lib/suites/debugger.ts

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,36 @@ export class DebuggerSuite extends RenderTest {
112112
}
113113
}
114114

115+
@test
116+
'debugger in class-backed component logs context message with named argument hint'() {
117+
let originalInfo = console.info;
118+
let messages: string[] = [];
119+
120+
console.info = (...args: unknown[]) => {
121+
messages.push(args.join(' '));
122+
};
123+
124+
try {
125+
resetDebuggerCallback();
126+
127+
this.registerComponent(
128+
'Glimmer',
129+
'DebugTest',
130+
'{{debugger}}',
131+
class extends GlimmerishComponent {}
132+
);
133+
134+
this.render('<DebugTest @foo="bar" />', {});
135+
136+
this.assert.deepEqual(messages, [
137+
"Use `context`, and `get(<path>)` to debug this template. For named arguments, use `get('@argName')`.",
138+
]);
139+
} finally {
140+
console.info = originalInfo;
141+
resetDebuggerCallback();
142+
}
143+
}
144+
115145
@test
116146
'can get locals'() {
117147
let expectedContext = {

packages/@glimmer/runtime/lib/compiled/opcodes/debugger.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ export type DebugCallback = (context: unknown, get: DebugGet) => void;
1616
function debugCallback(context: unknown, get: DebugGet): void {
1717
if (context !== null && context !== undefined) {
1818
// eslint-disable-next-line no-console
19-
console.info('Use `context`, and `get(<path>)` to debug this template.');
19+
console.info(
20+
"Use `context`, and `get(<path>)` to debug this template. For named arguments, use `get('@argName')`."
21+
);
2022

2123
// for example...
2224
context === get('this');

0 commit comments

Comments
 (0)