Cover RouterService query params during beforeModel redirect#21412
Open
olenderhub wants to merge 1 commit into
Open
Cover RouterService query params during beforeModel redirect#21412olenderhub wants to merge 1 commit into
olenderhub wants to merge 1 commit into
Conversation
olenderhub
changed the title
olenderhub
force-pushed
the
test/query-param-transition-service-beforeModel
branch
from
31ef067 to
6d777b1
Compare
Contributor
|
looks like tests pass here (and linting is failing) is it intended that tests pass? was this missing coverage that we should have? |
…service during beforeModel
olenderhub
force-pushed
the
test/query-param-transition-service-beforeModel
branch
from
6d777b1 to
cc01001
Compare
Contributor
Author
|
I added this as a regression test for the minimal repro from #17494. The test passes on current main, so the result seems to be that this behavior has already been fixed. I believe the test still reflects the reported scenario correctly, so I’d like to keep it as missing coverage unless you think there’s a better variant to cover. I rebase code, so linting pass now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds regression coverage for #17494.
This test covers RouterService#transitionTo with query params when the transition is initiated from an injected service during beforeModel, while another transition is already active.
It verifies that the redirect completes to the target route with the expected URL and controller query param state.
Part of #19609