Skip to content

Commit b633f2e

Browse files
committed
Clarified phrasing and filled remaining TBDs
1 parent 43b48e7 commit b633f2e

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

text/1169-route-manager-api.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ interface CreateRouteArgs {
6969

7070
#### `createRoute`
7171

72-
The `createRoute` method on the Route Manager is responsible for taking the Route’s factory and arguments and based on that return a `RouteStateBucket` .
72+
The `createRoute` method on the Route Manager is responsible for taking the Route’s factory and arguments and based on that return a `RouteStateBucket`. This is invoked by a Router.
7373

7474
***Note:** It is up to the manager to decide whether or not this method actually instantiates the factory or if that happens at a later time, depending on the specific lifecycle the manager implementation wants to provide.*
7575

@@ -79,7 +79,7 @@ The `RouteStateBucket` is a stable reference provided by the manager’s `create
7979

8080
#### `getDestroyable`
8181

82-
The `getDestroyable` method takes a `RouteStateBucket` and will return the `Destroyable` if applicable. This can be used by the manager implementation to wire up the lifetime of the route.
82+
The `getDestroyable` method takes a `RouteStateBucket` and will return the corresponding `Destroyable` if applicable.
8383

8484
### Determining which route manager to use
8585

@@ -301,15 +301,15 @@ Since this is not an Ember app developer facing feature the guides don’t need
301301

302302
## Drawbacks
303303

304-
TBD
304+
This introduces a new layer that isn't strictly required, but experiments would be much harder without it. Splitting the existing implementation will not be trivial to separate, but it is worth the effort long term.
305305

306306
## Alternatives
307307

308-
TBD
308+
The manager pattern is used across the Ember codebase with success and this is just the first step for formalizing improvements to the Router, alternatives were not explored.
309309

310310
## Unresolved questions
311311

312-
TBD
312+
None beyond implementation details.
313313

314314
## Addenda
315315

@@ -406,4 +406,4 @@ sequenceDiagram
406406
R->>AB: didExit()
407407
R->>A: didExit()
408408
409-
```
409+
```

0 commit comments

Comments
 (0)