Skip to content

Commit f12641b

Browse files
nickschotpichfl
authored andcommitted
Cleanup
1 parent 20bec75 commit f12641b

1 file changed

Lines changed: 4 additions & 47 deletions

File tree

text/0000-route-manager-api.md

Lines changed: 4 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,10 @@ suite: Leave as is
3131

3232
## Summary
3333

34-
> One paragraph explanation of the feature.
35-
3634
Define a generic Route Manager concept that can be used to implement new Route base classes as a stepping stone towards a new router.
3735

3836
## Motivation
3937

40-
> Why are we doing this? What use cases does it support? What is the expected
41-
outcome?
42-
4338
The intent of this RFC is to implement a generic Route Manager concept so that we’re able to provide room for experimentation and migration to a new router solution. It aims to provide a well-defined interface between the Router and Route concepts. Well-defined in this case means both API and lifecycle.
4439

4540
This will unlock the possibility of implementing new Route base classes while also making it easier to replace the current router.
@@ -51,24 +46,6 @@ This RFC is **not** intended to describe APIs that Ember app developers would ge
5146

5247
## Detailed design
5348

54-
> This is the bulk of the RFC.
55-
56-
> Explain the design in enough detail for somebody
57-
familiar with the framework to understand, and for somebody familiar with the
58-
implementation to implement. This should get into specifics and corner-cases,
59-
and include examples of how the feature is used. Any new terminology should be
60-
defined here.
61-
62-
> Please keep in mind any implications within the Ember ecosystem, such as:
63-
> - Lint rules (ember-template-lint, eslint-plugin-ember) that should be added, modified or removed
64-
> - Features that are replaced or made obsolete by this feature and should eventually be deprecated
65-
> - Ember Inspector and debuggability
66-
> - Server-side Rendering
67-
> - Ember Engines
68-
> - The Addon Ecosystem
69-
> - IDE Support
70-
> - Blueprints that should be added or modified
71-
7249
### Route Manager basics
7350

7451
The minimal API for a Route Manager consists of `capabilities`, `createRoute` and a `getDestroyable` method.
@@ -320,39 +297,19 @@ interface RouteManager {
320297

321298
## How we teach this
322299

323-
> What names and terminology work best for these concepts and why? How is this
324-
idea best presented? As a continuation of existing Ember patterns, or as a
325-
wholly new one?
326-
327-
> Would the acceptance of this proposal mean the Ember guides must be
328-
re-organized or altered? Does it change how Ember is taught to new users
329-
at any level?
330-
331-
> How should this feature be introduced and taught to existing Ember
332-
users?
333-
334-
> Keep in mind the variety of learning materials: API docs, guides, blog posts, tutorials, etc.
335-
336-
Since this is not an Ember-user facing feature the guides don’t need adjustment. Documentation will live in the API docs.
300+
Since this is not an Ember app developer facing feature the guides don’t need adjustment. Documentation will live in the API docs.
337301

338302
## Drawbacks
339303

340-
> Why should we *not* do this? Please consider the impact on teaching Ember,
341-
on the integration of this feature with other existing and planned features,
342-
on the impact of the API churn on existing apps, etc.
343-
344-
> There are tradeoffs to choosing any path, please attempt to identify them here.
304+
TBD
345305

346306
## Alternatives
347307

348-
> What other designs have been considered? What is the impact of not doing this?
349-
350-
> This section could also include prior art, that is, how other frameworks in the same domain have solved this problem.
308+
TBD
351309

352310
## Unresolved questions
353311

354-
> Optional, but suggested for first drafts. What parts of the design are still
355-
TBD?
312+
TBD
356313

357314
## Addenda
358315

0 commit comments

Comments
 (0)