Consolidate Template Concerns into @ember/template

[gossi]

Propose Consolidate Template Concerns into @ember/template

Rendered

Summary

This pull request is proposing a new RFC.

To succeed, it will need to pass into the Exploring Stage, followed by the Accepted Stage.

A Proposed or Exploring RFC may also move to the Closed Stage if it is withdrawn by the author or if it is rejected by the Ember team. This requires an "FCP to Close" period.

An FCP is required before merging this PR to advance to Accepted.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Ready for Released Stage.

Exploring Stage Description

This stage is entered when the Ember team believes the concept described in the RFC should be pursued, but the RFC may still need some more work, discussion, answers to open questions, and/or a champion before it can move to the next stage.

An RFC is moved into Exploring with consensus of the relevant teams. The relevant team expects to spend time helping to refine the proposal. The RFC remains a PR and will have an Exploring label applied.

An Exploring RFC that is successfully completed can move to Accepted with an FCP is required as in the existing process. It may also be moved to Closed with an FCP.

Accepted Stage Description

To move into the "accepted stage" the RFC must have complete prose and have successfully passed through an "FCP to Accept" period in which the community has weighed in and consensus has been achieved on the direction. The relevant teams believe that the proposal is well-specified and ready for implementation. The RFC has a champion within one of the relevant teams.

If there are unanswered questions, we have outlined them and expect that they will be answered before Ready for Release.

When the RFC is accepted, the PR will be merged, and automation will open a new PR to move the RFC to the Ready for Release stage. That PR should be used to track implementation progress and gain consensus to move to the next stage.

Checklist to move to Exploring

• The team believes the concepts described in the RFC should be pursued.
• The label S-Proposed is removed from the PR and the label S-Exploring is added.
• The Ember team is willing to work on the proposal to get it to Accepted

Checklist to move to Accepted

• This PR has had the Final Comment Period label has been added to start the FCP
• The RFC is announced in #news-and-announcements in the Ember Discord.
• The RFC has complete prose, is well-specified and ready for implementation.
  • All sections of the RFC are filled out.
  • Any unanswered questions are outlined and expected to be answered before Ready for Release.
  • "How we teach this?" is sufficiently filled out.
• The RFC has a champion within one of the relevant teams.
• The RFC has consensus after the FCP period.

[kategengler]

Discussed today in the RFC meeting. We do not want to proceed with this particular proposal but agree with the goal of limiting the number of imports.

Many of these helpers and modifiers are built-in to the framework as of 7.1 and no longer need to be imported.

There are extremely rough plans to move @glint/template and @glint/ember-tsc/types into ember-source.

We want to redesign modifiers and so do not want to move any part of the current ember-modifier into source.

We plan to deprecate the Component class from @ember/component.

[NullVoxPopuli]

After some time has passed since the default export of @ember/component is removed, we could then add / re-export @glimmer/component's default export as a named export of @ember/component -- a bit annoying of a timeline tho.

Additionally, folks could be quite upset with imports moving around -- so... it's a bit sad that we have to live with our mistakes, but we'd need a migration path for any import changes

[gossi]

Thanks @kategengler - makes sense. I still vouch for the template family.

I probably see the API narrows together when also re-claiming ember package, then ember/template can be the home to them.

Also then it's the right choice to make the glimmer component available from import { Component } from 'ember/template' - before it will cause more trouble then it solves. AI will be to stupid to import the right component and intellisense is more sense than intelli, leaving you on the wrong expectation for an auto-import.

[kategengler]

This is now a comment from me personally since the meeting was yesterday.

I think it would be very odd for Component to come from anything /template since they aren't just templates. The template naming also doesn't make sense for helpers that can be used both in and outside of the template.

As an aside, I don't really see issues with AI or my editor (in my case Webstorm) getting the correct import. There was a change v2.1.0 of @glimmer/component that may help with editors autocompletion of importing emberjs/ember.js#21014