Skip to content

Remove build hooks from v2 Addon Format RFC #507#1175

Open
NullVoxPopuli wants to merge 2 commits intomainfrom
nvp/remove-build-hooks
Open

Remove build hooks from v2 Addon Format RFC #507#1175
NullVoxPopuli wants to merge 2 commits intomainfrom
nvp/remove-build-hooks

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli commented Apr 20, 2026

Update #507

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/remove-build-hooks branch from 591aefb to 0acc4b1 Compare April 20, 2026 15:19
@mansona mansona changed the title Remove build hooks from #507 Remove build hooks from v2 Addon Format RFC Apr 20, 2026
@mansona mansona changed the title Remove build hooks from v2 Addon Format RFC Remove build hooks from v2 Addon Format RFC #507 Apr 20, 2026
@ef4
Copy link
Copy Markdown
Contributor

ef4 commented Apr 27, 2026

Notes from RFC review discussion:

  • skipBabel ended up with better standard alternatives (directly in your vite config or babel config, use the stock features for controlling which files get transpiled)
  • configure was for feeding the macro system, that has direct implementation in v2 apps (both the default one with compat in place and the "minimal" kind)
  • configureDependencies was for feeding the macro system recursively. It's a complex case that we don't really think is needed by all addons. Families of addons -- like Warp Drive -- with complicated compatibility needs have already done their own build tooling that they can control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants