Skip to content

Commit 9c3ccc2

Browse files
committed
refactor(generic): rename sidecars to extraContainers
Change the naming of the sidecars to extraContainers across generic chart components for clarity, reflecting a broader use case beyond sidecar containers.
1 parent fa7301e commit 9c3ccc2

5 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/charts/generic/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ Default probes can be overridden with `custom*Probe` or disabled entirely with `
190190
| `dnsConfig` | DNS configuration | `{}` |
191191
| `hostNetwork` | Use host network | `false` |
192192
| `initContainers` | Init containers | `[]` |
193-
| `sidecars` | Sidecar containers | `[]` |
193+
| `extraContainers` | Extra containers | `[]` |
194194

195195
## Service Account
196196

src/charts/generic/templates/cronjob.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,8 @@ spec:
168168
{{- include "common.tplvalues.render" (dict "value" . "context" $) | nindent 16 }}
169169
{{- end }}
170170
{{- end }}
171-
{{- if .Values.sidecars }}
172-
{{- include "common.tplvalues.render" (dict "value" .Values.sidecars "context" $) | nindent 12 }}
171+
{{- if .Values.extraContainers }}
172+
{{- include "common.tplvalues.render" (dict "value" .Values.extraContainers "context" $) | nindent 12 }}
173173
{{- end }}
174174
{{- if or .Values.persistence.enabled .Values.extraVolumes }}
175175
volumes:

src/charts/generic/templates/deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,8 @@ spec:
206206
{{- include "common.tplvalues.render" (dict "value" . "context" $) | nindent 12 }}
207207
{{- end }}
208208
{{- end }}
209-
{{- if .Values.sidecars }}
210-
{{- include "common.tplvalues.render" (dict "value" .Values.sidecars "context" $) | nindent 8 }}
209+
{{- if .Values.extraContainers }}
210+
{{- include "common.tplvalues.render" (dict "value" .Values.extraContainers "context" $) | nindent 8 }}
211211
{{- end }}
212212
{{- if or .Values.persistence.enabled .Values.extraVolumes }}
213213
volumes:

src/charts/generic/values.schema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@
179179
"dnsConfig": { "type": "object", "additionalProperties": true },
180180
"hostNetwork": { "type": "boolean" },
181181
"initContainers": { "type": "array" },
182-
"sidecars": { "type": "array" },
182+
"extraContainers": { "type": "array" },
183183
"serviceAccount": {
184184
"type": "object",
185185
"additionalProperties": false,

src/charts/generic/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ dnsConfig: {}
188188
hostNetwork: false
189189

190190
initContainers: []
191-
sidecars: []
191+
extraContainers: []
192192

193193
## @section Service account
194194
serviceAccount:

0 commit comments

Comments
 (0)