Skip to content

Commit d6917ad

Browse files
meenakshidembi691Meenakshi Dembi
andauthored
Added snapScheduleParameters in the modify method (#345)
Added snapScheduleParameters in the modify method so that snap schedule can be edited via playbook Co-authored-by: Meenakshi Dembi <meenakshi.dembi@emc.com>
1 parent 7ac580d commit d6917ad

3 files changed

Lines changed: 21 additions & 1 deletion

File tree

storops/unity/resource/filesystem.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def create(cls, cli, pool, nas_server, name, size, proto=None,
8080
def modify(self, size=None, is_thin=None, tiering_policy=None,
8181
user_cap=False, is_compression=None, access_policy=None,
8282
locking_policy=None, description=None,
83-
cifs_fs_parameters=None):
83+
cifs_fs_parameters=None, snap_schedule_parameters=None):
8484
sr = self.storage_resource
8585
if sr is None:
8686
raise ValueError('storage resource for filesystem {} not found.'
@@ -103,6 +103,8 @@ def modify(self, size=None, is_thin=None, tiering_policy=None,
103103
params['cifsFsParameters'] = cifs_fs_parameters
104104
if description is not None:
105105
params['description'] = description
106+
if snap_schedule_parameters:
107+
params['snapScheduleParameters'] = snap_schedule_parameters
106108

107109
if not params:
108110
return RestResponse('', self._cli)

storops_test/unity/resource/test_filesystem.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,13 @@ def test_modify_success_empty_description(self):
245245
fs.modify(description='')
246246
assert_that(fs.description, equal_to(''))
247247

248+
@patch_rest
249+
def test_modify_success_snap_schedule(self):
250+
fs = UnityFileSystem(cli=t_rest(), _id='fs_22')
251+
snap_schedule_parameters = {'snapSchedule': {'id': 'snapSch_1'}}
252+
resp = fs.modify(snap_schedule_parameters=snap_schedule_parameters)
253+
assert_that(resp.is_ok(), equal_to(True))
254+
248255
@patch_rest
249256
def test_delete_filesystem_async(self):
250257
fs = UnityFileSystem(_id='fs_14', cli=t_rest())

storops_test/unity/rest_data/storageResource/index.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,17 @@
348348
},
349349
"response": "size_too_small.json"
350350
},
351+
{
352+
"url": "/api/instances/storageResource/res_22/action/modifyFilesystem?compact=True",
353+
"body": {
354+
"snapScheduleParameters": {
355+
"snapSchedule": {
356+
"id": "snapSch_1"
357+
}
358+
}
359+
},
360+
"response": "empty.json"
361+
},
351362
{
352363
"url": "/api/types/storageResource/action/createFilesystem?compact=True",
353364
"body": {

0 commit comments

Comments
 (0)