Commit 7074e81
committed
fix(labeler): assert assessment-URL origin, not prefix (clears CodeQL)
CodeQL js/incomplete-url-substring-sanitization (high) flagged a test
assertion doing `assessmentUrl.startsWith("https://labels.example")` —
a prefix that `https://labels.example.evil.com` also satisfies. The
production URL builder (assessmentUrl, notification-triggers.ts) is sound
(`new URL(path, base)`); this was a test-only false positive. Parse the
URL and assert origin equality instead — stronger, and clears the rule.1 parent c539e22 commit 7074e81
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
487 | 487 | | |
488 | 488 | | |
489 | 489 | | |
490 | | - | |
| 490 | + | |
491 | 491 | | |
492 | 492 | | |
493 | 493 | | |
| |||
0 commit comments