feat(admin): fall back to the site title for admin branding#1707
Merged
Conversation
🦋 Changeset detectedLatest commit: 9a479eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The admin sidebar header (and the version line in its footer) always shows the hardcoded "EmDash" label unless a build-time
admin.siteNameis configured. Operators running several EmDash backends can't tell at a glance which site's admin they're in — every tab looks identical.This adds a WordPress-style fallback in the manifest route: when no explicit
admin.siteNameis configured,manifest.admin.siteNameis filled from the site's own title. Precedence:build-time
admin.siteName→ Site Title (Settings → General,site:title) → the title captured by the setup wizard (emdash:site_title) → the bundled "EmDash" default in the SPAThe admin SPA is untouched — the sidebar already renders
manifest.admin?.siteName || "EmDash", so the header, footer, andBrandIconalt text all pick this up automatically. Both option keys are read with a singlegetManybatch, wrapped in try/catch so a pre-setup database keeps the default. No behavior change for sites that configureadmin.siteNameor have no title yet.Complements #1505 (Site Icon as the admin favicon): favicon + sidebar title together make each backend instantly recognizable.
Discussion: #1706
Closes #
Type of change
Checklist
pnpm typecheckpasses (emdashpackage — clean)pnpm lintpasses (oxlint --type-aware --deny-warningsclean on the changed file)pnpm testpasses (or targeted tests for my change) — n/a: single manifest-route fallback with no existing route test harness; behavior verified manuallypnpm formathas been run (oxfmt+prettierclean)messages.pochangesemdash: minor)AI-generated code disclosure
Screenshots / test output
Single-file change in
packages/core/src/astro/routes/api/manifest.ts(+ changeset). Reuses the existingOptionsRepository.getManybatch read.