Beef up GaussianProcessSurrogate#745
Draft
AdrianSosic wants to merge 200 commits into
Draft
Conversation
* Cleans up the `GaussianProcessSurrogate` class * Adds transfer learning tests asserting that the mechanism works regardless of which tasks are represented in the training data
* Define mean functions for the available presets * Pass both mean and likelihood when instantiating preset
This was referenced May 7, 2026
DevPR, parent is #745 Makes the optimization criterion of the `GaussianProcessSurrogate` model configurable, in the form of a new `FitCriterion` enum. Potentially, this might be generalized to a class-based approach in the future if more configuration options are required, but for now the simpler solution serves all existing use cases.
Now properly handles the regular/task parameter split
DevPR, parent is #745 Adds the `BOTORCH` preset for GPs. ### Important information * I think it's critical to actually assert that the preset exactly recovers the BoTorch behavior, in the form of a test, for mainly two reasons: 1. The construction involves quite a few things to be configured, i.e. handling both singletask/multitask (the latter even requiring a new custom gpytorch module), setting all sorts of priors correctly, etc. Blindly believing that everything is correct and then just claiming `this is the BoTorch behavior` seems like a bad idea. The test ensures this explicitly. 2. It also as an automatic alert mechanism for all situations when something is changed on the BoTorch side, informing us about breaking changes that yield different behavior but are not fully documented (which happened already several times). * I've also invested quite some effort to test the new multitask mean logic, i.e. that it not only recovers the BoTorch logic but that it also fills *one* of the missing gaps that will ultimately make our transfer learning model *truely scale-invariant* w.r.t. the different input tasks. In particular, I made sure that the only missing piece is the noise model stratification, which should be added in a follow-up PR and is the analogous to the stratification over means shipped by this PR. (This explains the changes to the streamlit script.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rough agenda:
#743 (Cleanup)
#746 (GP Components)
EDBO/SMOOTHED_EDBOpresetkernelmachinery intocomponentmachinery using genericsgpytorchGP components#747 (Index Kernel)
IndexKernelclassPositiveIndexKernelclass#763 (Kernel Arithmetic)
Kernels#748 (Active Dimensions)
IndexKernellogic into kernel factory#776 (Kernel Factory Validation)
#752 (CHEN Preset)
CHENpreset#757 (BoTorch Preset)
BOTORCHpreset#789 (FitCriterion)
Must TODO
Optional TODO
HVARFNERpresetgpytorchGP componentsSettingattributeTo be added but out of scope