-
Notifications
You must be signed in to change notification settings - Fork 77
Add DiscreteBatchConstraint
#765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Scienfitz
wants to merge
43
commits into
main
Choose a base branch
from
feature/discrete_batch_constraint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
2d63d2b
Fix is_numeric typo in _FixedNumericalContinuousParameter
Scienfitz a84527f
Generalize subspace naming
Scienfitz 0d2a813
Extract _optimize_over_subspaces and add dispatch
Scienfitz dc8929e
Add hybrid constraint tests
Scienfitz 1c3aaf7
Filter by constraint type in cardinality utilities
Scienfitz c8928b8
Add DiscreteBatchConstraint class and validation
Scienfitz 8128968
Add partition machinery to SubspaceDiscrete
Scienfitz 5bb43cd
Add shuffle/replace to SubspaceContinuous
Scienfitz f78dab3
Add partition aggregation to SearchSpace
Scienfitz 48efdfe
Wire recommenders for DiscreteBatchConstraint
Scienfitz 6039baf
Add tests for DiscreteBatchConstraint
Scienfitz b79643f
Add DiscreteBatchConstraint to constraints userguide
Scienfitz 3417f91
Adjust constraint property names
Scienfitz 77818e9
Improve docstring language
Scienfitz 4e76ccf
Improve partition sampling
Scienfitz c7597e8
Split BotorchRecommender into submodules
Scienfitz 273567c
Rename subspace to partition
Scienfitz 7fdfb5c
Update CHANGELOG
Scienfitz 5ab2a6d
Improve docstring
Scienfitz 231f82a
Use consistent mask type hint in discrete recommender
Scienfitz f27cbca
Mention replacement in docstring
Scienfitz ce9c5e3
Mention computational expense
Scienfitz f8c1905
Simplify infinite iterator in inactive_parameter_combinations
AdrianSosic 32a6edf
Disable pydoclint yield type checking (DOC404) globally
AdrianSosic 86c87b2
Update docstring
Scienfitz d212060
Update signature
Scienfitz a835cd4
Update docstring
Scienfitz 41902c3
Fix formatting
Scienfitz d76a6a3
Improve language
Scienfitz 2f14ea6
Improve language
Scienfitz 5ebccad
Make formatting consistent
Scienfitz bc19835
Turn docstring into comment
Scienfitz a980be9
Improve tests
Scienfitz 615b581
Fix post-rebase issues
Scienfitz e6b60fc
Refactor constraint parametrization
AdrianSosic 7a5d725
Extract select_via_flat_index as shared utility
Scienfitz 1ee36c2
Rename partition to subset
Scienfitz 86aaaf9
Fix docstring
Scienfitz c1b33ac
Add formatting rule to AGENTS.md
Scienfitz eab2277
Simply subset iteration logic
AdrianSosic 6a73adb
Restore uniform sampling and exclusion of infeasible combos
AdrianSosic 9873539
Use numpy.unravel_index in select_via_flat_index
AdrianSosic 7210fcd
Dispatch recommenders based on n_theoretical_subsets
Scienfitz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.