Add support for cargo-generate on "cargo-gen" branch#227
Open
c-git wants to merge 24 commits into
Open
Conversation
Addresses other parts of the project where the word template is used
- Last part of job "Commit and Push" provided by Gemini and edited by me. - Verified email address based on https://github.com/actions/checkout#push-a-commit-using-the-built-in-token
ca0a429 to
649d7f1
Compare
This file is not needed by the end user
Wasn't able to get the job to trigger and wasn't important
Contributor
Author
|
Basically ready for review but need to discuss/decide on the open questions. Not sure if I should mark it as ready to review still. |
Corrected grammar and formatting in README.
Possible case for failure is incorrect update to the script of adding new files that need placeholders and not updating the script
This reverts commit dec6a78.
Contributor
Author
|
Seems to be working ok for me. I added the testing to mitigate a failure mode I discovered. If we were to add more rust files to the template then we may need to do replacements in those files as well. The added tests will at least catch those cases so we know we need to update the replacement code. |
Can't be exactly the same otherwise it will not fail any tests
May be created if run locally, won't shouldn't affect CI as git should ignore it
Contributor
Author
|
Please let me know if there is anything I need to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of idea number 2 from #169
Would love feedback on the open questions so we can see if this is good to merge as is.
Open question:
authorsin theCargo.toml. There are three options that I have found of so far.TODO
Add a CI job on that other branch to test if the expansion worksAbandoned because CI doesn't seem to trigger when expected and this isn't very important.- create-cargo-generate-template # For testing