Skip to content

Remove 64-bit atomics in main crate#8037

Merged
lucasmerlin merged 1 commit into
emilk:mainfrom
kay-lambdadelta:remove-64-bit-atomics
May 12, 2026
Merged

Remove 64-bit atomics in main crate#8037
lucasmerlin merged 1 commit into
emilk:mainfrom
kay-lambdadelta:remove-64-bit-atomics

Conversation

@kay-lambdadelta
Copy link
Copy Markdown
Contributor

This allows the base egui crate to run on platforms without 64 bit atomics

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 27, 2026

Preview available at https://egui-pr-preview.github.io/pr/8037-remove-64-bit-atomics
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

View snapshot changes at kitdiff

Copy link
Copy Markdown
Collaborator

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Maybe we can also forbid the use of AtomicU64 with clippy so we don't regress on this in the future?

@kay-lambdadelta
Copy link
Copy Markdown
Contributor Author

Thanks! Maybe we can also forbid the use of AtomicU64 with clippy so we don't regress on this in the future?

Something this would work I believe.

disallowed-types = [
    { path = "std::sync::atomic::AtomicU64", reason = "AtomicU64 is not supported on many common platforms, use AtomicU32 or AtomicUsize instead" }
]

@lucasmerlin lucasmerlin merged commit 2925b46 into emilk:main May 12, 2026
26 of 27 checks passed
@kay-lambdadelta kay-lambdadelta deleted the remove-64-bit-atomics branch May 12, 2026 21:26
@emilk emilk changed the title Remove 64 bit atomics in main crate Remove 64-bit atomics in main crate May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants