Panel: never overflow available width, nor max_width#8198
Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8198-emilkclamp-panel-size View snapshot changes at kitdiff |
This was referenced May 25, 2026
emilk
force-pushed
the
emilk/clamp-panel-size
branch
from
2c843a0 to
2a66e7f
Compare
lucasmerlin
approved these changes
May 26, 2026
Comment on lines
+658
to
+662
| let mut outer_rect = { | ||
| let mut outer_rect = available_rect; | ||
| self.side.set_rect_size(&mut outer_rect, outer_size); | ||
| outer_rect | ||
| }; |
Collaborator
There was a problem hiding this comment.
Suggested change
| let mut outer_rect = { | |
| let mut outer_rect = available_rect; | |
| self.side.set_rect_size(&mut outer_rect, outer_size); | |
| outer_rect | |
| }; | |
| let mut outer_rect = available_rect; | |
| self.side.set_rect_size(&mut outer_rect, outer_size); |
Owner
Author
|
I don't think this should be in a patch release - I worry this will change the behavior of some existing code, but I'm not 100% sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the behavior of
Panelto NEVER overflowPanel::max_size, nor the available space in the parent UI.If you do overflow it, the content will be silently clipped.