Avoid using internal bool in sparsity computation.

eminyouskn · metab0t · commit f9e9713b2ec5 · 2026-03-10T19:51:08.000+08:00
diff --git a/include/pyoptinterface/knitro_model.hpp b/include/pyoptinterface/knitro_model.hpp
@@ -168,9 +168,9 @@ struct CallbackEvaluator
 		{
 			jac_pattern_in.set(i, i, i);
 		}
-		fun.for_jac_sparsity(jac_pattern_in, false, false, true, jac_pattern_);
+		fun.for_jac_sparsity(jac_pattern_in, false, false, false, jac_pattern_);
 		std::vector<bool> select_rows(ny, true);
-		fun.rev_hes_sparsity(select_rows, false, true, hess_pattern_);
+		fun.rev_hes_sparsity(select_rows, false, false, hess_pattern_);
 		auto &hess_rows = hess_pattern_.row();
 		auto &hess_cols = hess_pattern_.col();
 		for (size_t k = 0; k < hess_pattern_.nnz(); k++)

Original file line number	Diff line number	Diff line change
`@@ -168,9 +168,9 @@ struct CallbackEvaluator`
`168`	`168`	`{`
`169`	`169`	`jac_pattern_in.set(i, i, i);`
`170`	`170`	`}`
`171`		`- fun.for_jac_sparsity(jac_pattern_in, false, false, true, jac_pattern_);`
	`171`	`+ fun.for_jac_sparsity(jac_pattern_in, false, false, false, jac_pattern_);`
`172`	`172`	`std::vector<bool> select_rows(ny, true);`
`173`		`- fun.rev_hes_sparsity(select_rows, false, true, hess_pattern_);`
	`173`	`+ fun.rev_hes_sparsity(select_rows, false, false, hess_pattern_);`
`174`	`174`	`auto &hess_rows = hess_pattern_.row();`
`175`	`175`	`auto &hess_cols = hess_pattern_.col();`
`176`	`176`	`for (size_t k = 0; k < hess_pattern_.nnz(); k++)`