cnn: Try to support both int8 and fp32 for external

A bit tricky since one needs to avoid duplicate symbols,
and the MicroPython build system is quite opinionated

Author: jonnor

src/emlearn_cnn_fp32/emlearn_cnn_fp32.c

@@ -0,0 +1,6 @@
+/*
+ * emlearn_cnn_fp32 wrapper
+ * This file sets CONFIG_FP32 and includes the main mod_cnn.c
+ */
+#define CONFIG_FP32
+#include "../tinymaix_cnn/mod_cnn.c"

src/emlearn_cnn_fp32/emlearn_cnn_fp32.py

@@ -1,6 +1,6 @@
 # emlearn_cnn_fp32 - wrapper for frozen unix build
 # Imports the native C module compiled with fp32 configuration
 try:
-    from tinymaix_cnn_fp32_native import *
+    from emlearn_cnn_fp32_native import *
 except ImportError:
     pass

src/emlearn_cnn_fp32/micropython.mk

@@ -1,18 +1,15 @@
 # emlearn_cnn_fp32 wrapper for Unix port
-# Compiles mod_cnn.c with fp32 configuration
+# This wrapper sets CONFIG_FP32 before including mod_cnn.c
 
 CNN_SRC := $(USERMOD_DIR)/../tinymaix_cnn
 
-# Add C source file from tinymaix_cnn
-SRC_USERMOD_C += $(CNN_SRC)/mod_cnn.c
+# Add wrapper C file which defines CONFIG_FP32
+SRC_USERMOD_C += $(USERMOD_DIR)/emlearn_cnn_fp32.c
 
-# Include paths
+# Include paths - need to include tm_port.h location
 CFLAGS_USERMOD += -I$(CNN_SRC)/fp32
 CFLAGS_USERMOD += -I$(CNN_SRC)/../../dependencies/TinyMaix/include
 CFLAGS_USERMOD += -I$(CNN_SRC)/../../dependencies/TinyMaix/src
 
-# Compile flags
+# Compile flags to suppress TinyMaix warnings
 CFLAGS_USERMOD += -Wno-error=unused-variable -Wno-error=multichar -Wdouble-promotion
-
-# Define CONFIG_FP32 for the C code
-CFLAGS_USERMOD += -DCONFIG_FP32

src/emlearn_cnn_int8/emlearn_cnn_int8.c

@@ -0,0 +1,6 @@
+/*
+ * emlearn_cnn_int8 wrapper
+ * This file sets CONFIG_INT8 and includes the main mod_cnn.c
+ */
+#define CONFIG_INT8
+#include "../tinymaix_cnn/mod_cnn.c"

src/emlearn_cnn_int8/emlearn_cnn_int8.py

@@ -0,0 +1,6 @@
+# emlearn_cnn_int8 - wrapper for frozen unix build
+# Imports the native C module compiled with int8 configuration
+try:
+    from emlearn_cnn_int8_native import *
+except ImportError:
+    pass

src/emlearn_cnn_int8/micropython.mk

@@ -0,0 +1,15 @@
+# emlearn_cnn_int8 wrapper for Unix port
+# This wrapper sets CONFIG_INT8 before including mod_cnn.c
+
+CNN_SRC := $(USERMOD_DIR)/../tinymaix_cnn
+
+# Add wrapper C file which defines CONFIG_INT8
+SRC_USERMOD_C += $(USERMOD_DIR)/emlearn_cnn_int8.c
+
+# Include paths - need to include tm_port.h location
+CFLAGS_USERMOD += -I$(CNN_SRC)/int8
+CFLAGS_USERMOD += -I$(CNN_SRC)/../../dependencies/TinyMaix/include
+CFLAGS_USERMOD += -I$(CNN_SRC)/../../dependencies/TinyMaix/src
+
+# Compile flags to suppress TinyMaix warnings
+CFLAGS_USERMOD += -Wno-error=unused-variable -Wno-error=multichar -Wdouble-promotion

src/manifest_unix.py

@@ -4,6 +4,7 @@
 # Ref https://docs.micropython.org/en/latest/reference/manifest.html
 module("emlearn_trees.py", base_path='./emlearn_trees')
 module("emlearn_kmeans.py", base_path='./emlearn_kmeans')
+module("emlearn_cnn_int8.py", base_path='./emlearn_cnn_int8')
 module("emlearn_cnn_fp32.py", base_path='./emlearn_cnn_fp32')
 module("emlearn_fft.py", base_path='./emlearn_fft')
 module("emlearn_linreg.py", base_path='./emlearn_linreg')

src/tinymaix_cnn/fp32/tm_port.h

@@ -44,11 +44,16 @@ limitations under the License.
 #define TM_WEAK         __attribute__((weak))
 
 // Disable "static" (non-const) globals, since they are not supported by MicroPython mpy_ld.py
-#define TM_STATIC       
+// But when building multiple variants, we need static to avoid duplicate definitions
+#ifdef CONFIG_FP32
+#define TM_STATIC static
+#else
+#define TM_STATIC
+#endif       
 
 // Use MicroPython for dynamic allocation
 #define tm_malloc(x)   m_malloc(x)
-#define tm_free(x)     mod_cnn_free(x)
+#define tm_free(x)     CNN_FREE(x)
 
 // FIXME: set theese to use MicroPython primitives
 

src/tinymaix_cnn/int8/tm_port.h

@@ -44,11 +44,16 @@ limitations under the License.
 #define TM_WEAK         __attribute__((weak))
 
 // Disable "static" (non-const) globals, since they are not supported by MicroPython mpy_ld.py
-#define TM_STATIC       
+// But when building multiple variants, we need static to avoid duplicate definitions
+#ifdef CONFIG_INT8
+#define TM_STATIC static
+#else
+#define TM_STATIC
+#endif       
 
 // Use MicroPython for dynamic allocation
 #define tm_malloc(x)   m_malloc(x)
-#define tm_free(x)     mod_cnn_free(x)
+#define tm_free(x)     CNN_FREE(x)
 
 // FIXME: set theese to use MicroPython primitives
 

src/tinymaix_cnn/mod_cnn.c

@@ -5,8 +5,23 @@
 #include "py/runtime.h"
 #endif
 
+// Define unique symbol names based on CONFIG
+#ifdef CONFIG_FP32
+#define CNN_TYPE mod_cnn_fp32_type
+#define CNN_CMODULE mod_cnn_fp32_cmodule
+#define CNN_FREE mod_cnn_fp32_free
+#elif defined(CONFIG_INT8)
+#define CNN_TYPE mod_cnn_int8_type
+#define CNN_CMODULE mod_cnn_int8_cmodule
+#define CNN_FREE mod_cnn_int8_free
+#else
+#define CNN_TYPE mod_cnn_int8_type
+#define CNN_CMODULE mod_cnn_int8_cmodule
+#define CNN_FREE mod_cnn_int8_free
+#endif
 
-void mod_cnn_free(void *ptr);
+// Forward declaration for tm_port.h
+void CNN_FREE(void *ptr);
 
 // TinyMaix config
 #include "./tm_port.h"
@@ -81,18 +96,18 @@ typedef struct _mp_obj_mod_cnn_t {
 } mp_obj_mod_cnn_t;
 
 #if MICROPY_ENABLE_DYNRUNTIME
-mp_obj_full_type_t mod_cnn_type;
+mp_obj_full_type_t CNN_TYPE;
 #else
-static const mp_obj_type_t mod_cnn_type;
+static const mp_obj_type_t CNN_TYPE;
 #endif
 
 
-void mod_cnn_free(void *ptr)
+void CNN_FREE(void *ptr)
 {
 #if MICROPY_ENABLE_DYNRUNTIME
     return m_free(ptr);
 #else
-    return m_del(void *, ptr, 0); // XXX: not sure if safe
+    return m_del(void *, ptr, 0);
 #endif
 }
 
@@ -116,7 +131,7 @@ static mp_obj_t mod_cnn_new(mp_obj_t model_data_obj) {
     const int model_data_length = bufinfo.len / sizeof(*model_data_buffer);
 
     // Construct object
-    mp_obj_mod_cnn_t *o = mp_obj_malloc(mp_obj_mod_cnn_t, (mp_obj_type_t *)&mod_cnn_type);
+    mp_obj_mod_cnn_t *o = mp_obj_malloc(mp_obj_mod_cnn_t, (mp_obj_type_t *)&CNN_TYPE);
     tm_mdl_t *model = &o->model;
 
     // Copy the model data
@@ -283,15 +298,15 @@ mp_obj_t mpy_init(mp_obj_fun_bc_t *self, size_t n_args, size_t n_kw, mp_obj_t *a
 
     mp_store_global(MP_QSTR_new, MP_OBJ_FROM_PTR(&mod_cnn_new_obj));
 
-    mod_cnn_type.base.type = (void*)&mp_fun_table.type_type;
-    mod_cnn_type.flags = MP_TYPE_FLAG_ITER_IS_CUSTOM;
-    mod_cnn_type.name = MP_QSTR_tinymaixcnn;
+    CNN_TYPE.base.type = (void*)&mp_fun_table.type_type;
+    CNN_TYPE.flags = MP_TYPE_FLAG_ITER_IS_CUSTOM;
+    CNN_TYPE.name = MP_QSTR_tinymaixcnn;
     // methods
     mod_locals_dict_table[0] = (mp_map_elem_t){ MP_OBJ_NEW_QSTR(MP_QSTR_run), MP_OBJ_FROM_PTR(&mod_cnn_run_obj) };
     mod_locals_dict_table[1] = (mp_map_elem_t){ MP_OBJ_NEW_QSTR(MP_QSTR___del__), MP_OBJ_FROM_PTR(&mod_cnn_del_obj) };
     mod_locals_dict_table[2] = (mp_map_elem_t){ MP_OBJ_NEW_QSTR(MP_QSTR_output_dimensions), MP_OBJ_FROM_PTR(&mod_cnn_output_dimensions_obj) };
 
-    MP_OBJ_TYPE_SET_SLOT(&mod_cnn_type, locals_dict, (void*)&mod_locals_dict, 2);
+    MP_OBJ_TYPE_SET_SLOT(&CNN_TYPE, locals_dict, (void*)&mod_locals_dict, 2);
 
     // This must be last, it restores the globals dict
     MP_DYNRUNTIME_INIT_EXIT
@@ -308,7 +323,7 @@ static MP_DEFINE_CONST_DICT(mod_cnn_locals_dict, mod_cnn_locals_dict_table);
 
 
 static MP_DEFINE_CONST_OBJ_TYPE(
-    mod_cnn_type,
+    CNN_TYPE,
     MP_QSTR_tinymaix_cnn,
     MP_TYPE_FLAG_NONE,
     locals_dict, &mod_cnn_locals_dict
@@ -320,17 +335,17 @@ static const mp_rom_map_elem_t mod_cnn_globals_table[] = {
 };
 static MP_DEFINE_CONST_DICT(mod_cnn_globals, mod_cnn_globals_table);
 
-const mp_obj_module_t mod_cnn_cmodule = {
+const mp_obj_module_t CNN_CMODULE = {
     .base = { &mp_type_module },
     .globals = (mp_obj_dict_t *)&mod_cnn_globals,
 };
 
 // Module name depends on CONFIG
 #ifdef CONFIG_FP32
-MP_REGISTER_MODULE(MP_QSTR_tinymaix_cnn_fp32_native, mod_cnn_cmodule);
+MP_REGISTER_MODULE(MP_QSTR_emlearn_cnn_fp32_native, CNN_CMODULE);
+#elif defined(CONFIG_INT8)
+MP_REGISTER_MODULE(MP_QSTR_emlearn_cnn_int8_native, CNN_CMODULE);
 #else
-MP_REGISTER_MODULE(MP_QSTR_emlearn_cnn_int8, mod_cnn_cmodule);
+MP_REGISTER_MODULE(MP_QSTR_emlearn_cnn_int8_native, CNN_CMODULE);
 #endif
 #endif
-
-