From be0ccb359c75891593853be42e980d7988f202e5 Mon Sep 17 00:00:00 2001 From: Alexey Kostevich Date: Tue, 7 Apr 2020 23:31:20 +1000 Subject: [PATCH 1/3] [BUGFIX] Fix the issue with a sidenav show button being scrolled with the main content --- addon/styles/addon.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addon/styles/addon.css b/addon/styles/addon.css index b5f6c49..7ecdad1 100644 --- a/addon/styles/addon.css +++ b/addon/styles/addon.css @@ -159,7 +159,7 @@ body { .field-guide-show-sidenav { display: none; - position: absolute; + position: fixed; top:5px; left:5px; From 8d703780cfeaccbe87ee08748468f16aa21dfa0e Mon Sep 17 00:00:00 2001 From: Alexey Kostevich Date: Tue, 7 Apr 2020 23:54:26 +1000 Subject: [PATCH 2/3] [BUGFIX] Fix the issue with the sidenav being overlapped by the main content. --- addon/styles/addon.css | 12 +++++++++--- addon/templates/application.hbs | 12 ++++++------ 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/addon/styles/addon.css b/addon/styles/addon.css index 7ecdad1..295a668 100644 --- a/addon/styles/addon.css +++ b/addon/styles/addon.css @@ -2,7 +2,7 @@ * This is the only resetting we will do. Any other resets need to come from * the addon itself. We recommend implementing normalize.css */ -body { + body { margin: 0; } @@ -18,6 +18,7 @@ body { top: 0; left: 0; bottom: 0; + z-index: 1; display: flex; flex-direction: column; @@ -28,7 +29,6 @@ body { border-right-color: #DDD; border-right-width: 1px; border-right-style: solid; - } .field-guide-logo { @@ -97,7 +97,6 @@ body { display: flex; flex-direction: column; justify-content: space-between; - } .field-guide-wrapper-full-height > main { @@ -105,6 +104,12 @@ body { padding: 2em 4em; } +.field-guide-main-content { + /* Create a new stacking context for a user's content. */ + position: relative; + z-index: 0; +} + .field-guide-footer { margin-left: 241px; background-color: #EEE; @@ -162,6 +167,7 @@ body { position: fixed; top:5px; left:5px; + z-index: 1; background: none; color: inherit; diff --git a/addon/templates/application.hbs b/addon/templates/application.hbs index d946fb3..b4e88e9 100644 --- a/addon/templates/application.hbs +++ b/addon/templates/application.hbs @@ -16,12 +16,12 @@
-
- + +
{{outlet}}