Skip to content

Fix layout issues with the sidenav #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexeykostevich wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix layout issues with the sidenav #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be0ccb3
[BUGFIX] Fix the issue with a sidenav show button being scrolled with…
Apr 7, 2020
8d70378
[BUGFIX] Fix the issue with the sidenav being overlapped by the main …
Apr 7, 2020
e497bbd
[BUGFIX] Reset styles for socials
Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions addon/styles/addon.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* This is the only resetting we will do. Any other resets need to come from
* the addon itself. We recommend implementing normalize.css
*/
body {
body {
margin: 0;
}

Expand All @@ -18,6 +18,7 @@ body {
top: 0;
left: 0;
bottom: 0;
z-index: 1;

display: flex;
flex-direction: column;
Expand All @@ -28,7 +29,6 @@ body {
border-right-color: #DDD;
border-right-width: 1px;
border-right-style: solid;

}

.field-guide-logo {
Expand Down Expand Up @@ -97,14 +97,19 @@ body {
display: flex;
flex-direction: column;
justify-content: space-between;

}

.field-guide-wrapper-full-height > main {
margin-left: 241px;
padding: 2em 4em;
}

.field-guide-main-content {
/* Create a new stacking context for a user's content. */
position: relative;
z-index: 0;
}

.field-guide-footer {
margin-left: 241px;
background-color: #EEE;
Expand Down Expand Up @@ -138,7 +143,7 @@ body {
.field-guide-socials li {
display: inline-block;
padding: 0;
marign: 0;
margin: 0;
}

.self-executing-code-block {
Expand All @@ -159,9 +164,10 @@ body {
.field-guide-show-sidenav {
display: none;

position: absolute;
position: fixed;
top:5px;
left:5px;
z-index: 1;

background: none;
color: inherit;
Expand Down
12 changes: 6 additions & 6 deletions addon/templates/application.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
</div>
</nav>
<div class="field-guide-wrapper-full-height">
<main>
<button class="field-guide-show-sidenav" {{action (mut showSideNav) (not showSideNav)}}>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32" height="25">
<path d="M4 10h24a2 2 0 0 0 0-4H4a2 2 0 0 0 0 4zm24 4H4a2 2 0 0 0 0 4h24a2 2 0 0 0 0-4zm0 8H4a2 2 0 0 0 0 4h24a2 2 0 0 0 0-4z"/>
</svg>
</button>
<button class="field-guide-show-sidenav" {{action (mut showSideNav) (not showSideNav)}}>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32" height="25">
<path d="M4 10h24a2 2 0 0 0 0-4H4a2 2 0 0 0 0 4zm24 4H4a2 2 0 0 0 0 4h24a2 2 0 0 0 0-4zm0 8H4a2 2 0 0 0 0 4h24a2 2 0 0 0 0-4z"/>
</svg>
</button>
<main class="field-guide-main-content">
{{outlet}}
</main>
<footer class="field-guide-footer">
Expand Down