Conversation
Related To Issue: 35 What's Wrong: * Compilation of BoardContext failed on develop because BoardContext.cpp declared linker symbols using the LINKER_TYPED_SYMBOL macro, but did not include the <cortex/linker.hpp> header where the macro is defined. * BoardContext.hpp declared GetEthernet() and GlobalContext.cpp enlisted it in the SuperLoop, but the net/ethernet module and headers are not yet present on develop, causing compile-time errors. How Was it Fixed (if not obvious): * Included <cortex/linker.hpp> in BoardContext.cpp to define LINKER_TYPED_SYMBOL. * Commented out the GetEthernet() declaration in BoardContext.hpp and its enlistment in GlobalContext.cpp until the net module is merged. * Removed the unused jarnax/net/ethernet/Driver.hpp header inclusion from Demo.hpp. * AI generated the header inclusion additions and commented out the premature references, while a human reviewed the changes and executed the builds and tests. What side effects does this have (could be none): * None. Fixes compilation errors for targets compiled under host native presets. Which builds did you run to make sure they build? [x] arm-none-eabi-gcc Cortex M4 [x] arm-none-eabi-gcc Cortex M7 [x] (Apple) Native Clang [ ] (Apple) Homebrew GCC [x] (Apple) Homebrew LLVM How Do We Know and Can Show It's Fixed: * Host-native unit tests in all active suites compile and pass successfully. Which Unittest Series did you Check? [x] (Apple) Homebrew LLVM Did this affect any on-target builds? If so which were tested? [x] STM32H753ZI board
Owner
Author
build-all-presets.py Execution ResultsThe script was run locally to verify all configurations:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the compilation break of the target/board libraries on the
developbranch.Changes
<cortex/linker.hpp>inBoardContext.cppto correctly define theLINKER_TYPED_SYMBOLmacro.GetEthernet()declaration inBoardContext.hppand its enlistment inGlobalContext.cppsince the network stack files are not yet present ondevelop.jarnax/net/ethernet/Driver.hppheader inclusion fromDemo.hpp.Closes #35