Skip to content

Commit 0630136

Browse files
authored
Clean up test_this_in_dyncall. NFC (#26880)
For some reason when this test was added in #18169 the file name was called `no_this_in_dyncall` despite the fact that the test name and comment and content seem to imply that it is for testing the presence of this in dyncall *is* allowed.
1 parent d137bef commit 0630136

4 files changed

Lines changed: 4 additions & 7 deletions

File tree

test/test_other.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12295,16 +12295,13 @@ def test_old_makeDynCall_syntax(self):
1229512295

1229612296
# Test that {{{ makeDynCall('sig', 'this.foo') }}} macro works, i.e. when 'this.' is referenced inside the macro block.
1229712297
# For this test verify the different build options that generate anonymous enclosing function scopes. (DYNCALLS and MEMORY64)
12298+
@also_with_wasm64
1229812299
@parameterized({
12299-
'plain': [[]],
12300-
'dyncalls': [['-sDYNCALLS']],
12300+
'': ([],),
12301+
'dyncalls': (['-sDYNCALLS'],),
1230112302
})
1230212303
def test_this_in_dyncall(self, args):
12303-
self.do_run_in_out_file_test('no_this_in_dyncall.c', cflags=['--js-library', test_file('no_this_in_dyncall.js')] + args)
12304-
12305-
@requires_wasm64
12306-
def test_this_in_dyncall_memory64(self):
12307-
self.do_run_in_out_file_test('no_this_in_dyncall.c', cflags=['--js-library', test_file('no_this_in_dyncall.js'), '-sMEMORY64'])
12304+
self.do_run_in_out_file_test('test_this_in_dyncall.c', cflags=['--js-library', test_file('test_this_in_dyncall.js')] + args)
1230812305

1230912306
# Tests that dynCalls are produced in Closure-safe way in DYNCALLS mode when no actual dynCalls are used
1231012307
@parameterized({

0 commit comments

Comments
 (0)