Bump safari from 14.0 to 14.1 for even more wins!

For example, we can completely remove the sign extension lowering pass
now.

Author: sbc100

ChangeLog.md

@@ -47,15 +47,18 @@ See docs/process.md for more on how version tagging works.
   `-sMEMORY64` and/or `--target=wasm64`. (#26765)
 - The filesystem opteration that create new files now honor the global umask,
   which defaults for 0o222 and can be updated by calling `umask()`. (#50739)
-
-5.0.6 - 04/14/26
-----------------
 - The minimum versions of browser engines supported by emscirpten generated
   code was bumped, allowing us to remove our internal support for transpilation
   via babel:
     MIN_CHROME_VERSION: 74 -> 85
     MIN_FIREFOX_VERSION: 68 -> 79
-    MIN_SAFARI_VERSION: 12.2 -> 14.0
+    MIN_SAFARI_VERSION: 12.2 -> 14.1
+  This allows us to assume that features such as mutable-globals, and sign-ext,
+  and threading, are univerally available and disabling these is not longer
+  possible.
+
+5.0.6 - 04/14/26
+----------------
 - The minimum version of node supported by the generated code was bumped from
   v12.22.0 to v18.3.0. (#26604)
 - The DETERMINISTIC settings was marked as deprecated (#26653)

src/settings.js

@@ -1892,7 +1892,7 @@ var MIN_FIREFOX_VERSION = 79;
 // Multithreaded Emscripten code will need Safari 12.2 (iPhone 5s+) at minimum,
 // with support for DedicatedWorkerGlobalScope.name parameter.
 // MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
-// Minimum supported value is 140000 which was released on 2020-09-16 (see
+// Minimum supported value is 140100 which was released on 2021-04-26 (see
 // feature_matrix.py).
 // [link]
 var MIN_SAFARI_VERSION = 150000;

test/codesize/test_codesize_hello_dylink_all.json

@@ -1,7 +1,7 @@
 {
   "a.out.js": 244573,
-  "a.out.nodebug.wasm": 578045,
-  "total": 822618,
+  "a.out.nodebug.wasm": 578052,
+  "total": 822625,
   "sent": [
     "IMG_Init",
     "IMG_Load",

test/other/test_signext_lowering.c

@@ -256,10 +256,6 @@ def es6_module_workers_disabled():
 requires_offscreen_canvas = skipIfFeatureNotAvailable('EMTEST_LACKS_OFFSCREEN_CANVAS', Feature.OFFSCREENCANVAS_SUPPORT, 'This test requires a browser with OffscreenCanvas')
 requires_es6_workers = skipIfFeatureNotAvailable('EMTEST_LACKS_ES6_WORKERS', Feature.WORKER_ES6_MODULES, 'This test requires a browser with ES6 Module Workers support')
 requires_growable_arraybuffers = skipIfFeatureNotAvailable('EMTEST_LACKS_GROWABLE_ARRAYBUFFERS', Feature.GROWABLE_ARRAYBUFFERS, 'This test requires a browser that supports growable ArrayBuffers')
-# N.b. not all SharedArrayBuffer requiring tests are annotated with this decorator, since at this point there are so many of such tests.
-# As a middle ground, if a test has a name 'thread' or 'wasm_worker' in it, then it does not need decorating. To run all single-threaded tests in
-# the suite, one can run "EMTEST_LACKS_SHARED_ARRAY_BUFFER=1 test/runner browser skip:browser.test_*thread* skip:browser.test_*wasm_worker* skip:browser.test_*audio_worklet*"
-requires_shared_array_buffer = skipIfFeatureNotAvailable('EMTEST_LACKS_SHARED_ARRAY_BUFFER', Feature.THREADS, 'This test requires a browser with SharedArrayBuffer support')
 
 
 class browser(BrowserCore):
@@ -2538,7 +2534,7 @@ def test_doublestart_bug(self):
     'closure': (['-O2', '-g1', '--closure=1', '-sHTML5_SUPPORT_DEFERRING_USER_SENSITIVE_REQUESTS=0'],),
     'pthread': (['-pthread'],),
     'proxy_to_pthread': (['-pthread', '-sPROXY_TO_PTHREAD'],),
-    'legacy': (['-sMIN_FIREFOX_VERSION=0', '-sMIN_SAFARI_VERSION=0', '-sMIN_CHROME_VERSION=0', '-Wno-transpile'],),
+    'legacy': (['-sMIN_FIREFOX_VERSION=0', '-sMIN_SAFARI_VERSION=0', '-sMIN_CHROME_VERSION=0'],),
   })
   def test_html5_core(self, opts):
     if self.is_wasm64() and '-sMIN_CHROME_VERSION=0' in opts:
@@ -2641,7 +2637,7 @@ def test_webgl_unmasked_vendor_webgl(self):
 
   @requires_graphics_hardware
   @parameterized({
-    'legacy_browser': (['-sMIN_CHROME_VERSION=0', '-Wno-transpile'],),
+    'legacy_browser': (['-sMIN_CHROME_VERSION=0'],),
     'closure': (['-O2', '-g1', '--closure=1'],),
     'full_es2': (['-sFULL_ES2'],),
   })
@@ -3489,7 +3485,6 @@ def test_dlopen_async(self):
     self.emcc('side.c', ['-o', 'libside.so', '-sSIDE_MODULE'])
     self.btest_exit('other/test_dlopen_async.c', cflags=['-sMAIN_MODULE=2'])
 
-  @requires_shared_array_buffer
   def test_dlopen_blocking(self):
     self.emcc('other/test_dlopen_blocking_side.c', ['-o', 'libside.so', '-sSIDE_MODULE', '-pthread', '-Wno-experimental'])
     # Attempt to use dlopen the side module (without preloading) should fail on the main thread
@@ -4540,7 +4535,6 @@ def test_fetch_to_memory_async(self):
     create_file('myfile.dat', 'hello world\n' * 1000)
     self.btest_exit('fetch/test_fetch_to_memory_async.c', cflags=['-sFETCH'])
 
-  @requires_shared_array_buffer
   def test_fetch_to_memory_sync(self):
     create_file('myfile.dat', 'hello world\n' * 1000)
     self.btest_exit('fetch/test_fetch_to_memory_sync.c', cflags=['-sFETCH', '-pthread', '-sPROXY_TO_PTHREAD'])
@@ -4873,11 +4867,9 @@ def test_emscripten_request_animation_frame_loop(self):
   def test_request_animation_frame(self):
     self.btest_exit('test_request_animation_frame.c')
 
-  @requires_shared_array_buffer
   def test_emscripten_set_timeout(self):
     self.btest_exit('emscripten_set_timeout.c', cflags=['-pthread', '-sPROXY_TO_PTHREAD'])
 
-  @requires_shared_array_buffer
   def test_emscripten_set_timeout_loop(self):
     self.btest_exit('emscripten_set_timeout_loop.c', cflags=['-pthread', '-sPROXY_TO_PTHREAD'])
 
@@ -4887,7 +4879,6 @@ def test_emscripten_set_immediate(self):
   def test_emscripten_set_immediate_loop(self):
     self.btest_exit('emscripten_set_immediate_loop.c')
 
-  @requires_shared_array_buffer
   def test_emscripten_set_interval(self):
     self.btest_exit('emscripten_set_interval.c', cflags=['-pthread', '-sPROXY_TO_PTHREAD'])
 
@@ -5466,15 +5457,13 @@ def test_full_js_library_strict(self):
     'audio_params_disabled': (['-sAUDIO_WORKLET_SUPPORT_AUDIO_PARAMS=0'],),
   })
   @requires_sound_hardware
-  @requires_shared_array_buffer
   def test_audio_worklet(self, args):
     if '-sEXPORT_ES6' in args and es6_module_workers_disabled():
       self.skipTest('This test requires a browser with ES6 Module Workers support')
     self.btest_exit('webaudio/audioworklet.c', cflags=['-sAUDIO_WORKLET', '-sWASM_WORKERS', '-DTEST_AND_EXIT'] + args)
 
   # Tests that audioworklets and workers can be used at the same time
   # Note: doesn't need audio hardware (and has no AW code that tests 2GB or wasm64)
-  @requires_shared_array_buffer
   def test_audio_worklet_worker(self):
     self.btest_exit('webaudio/audioworklet_worker.c', cflags=['-sAUDIO_WORKLET', '-sWASM_WORKERS'])
 
@@ -5484,7 +5473,6 @@ def test_audio_worklet_worker(self):
     'closure': (['--closure', '1', '-Oz'],),
   })
   # Note: doesn't need audio hardware (and has no AW code that tests 2GB or wasm64)
-  @requires_shared_array_buffer
   def test_audio_worklet_post_function(self, args):
     self.btest_exit('webaudio/audioworklet_post_function.c', cflags=['-sAUDIO_WORKLET', '-sWASM_WORKERS'] + args)
 
@@ -5493,7 +5481,6 @@ def test_audio_worklet_post_function(self, args):
     'closure': (['--closure', '1', '-Oz'],),
   })
   @requires_sound_hardware
-  @requires_shared_array_buffer
   def test_audio_worklet_modularize(self, args):
     self.btest_exit('webaudio/audioworklet.c', cflags=['-sAUDIO_WORKLET', '-sWASM_WORKERS', '-sMODULARIZE=1', '-DTEST_AND_EXIT'] + args)
 
@@ -5505,7 +5492,6 @@ def test_audio_worklet_modularize(self, args):
     'minimal_with_closure': (['-sMINIMAL_RUNTIME', '--closure=1', '-Oz'],),
   })
   @requires_sound_hardware
-  @requires_shared_array_buffer
   def test_audio_worklet_params_mixing(self, args):
     os.mkdir('audio_files')
     copy_asset('webaudio/audio_files/emscripten-beat.mp3', 'audio_files/')
@@ -5514,7 +5500,6 @@ def test_audio_worklet_params_mixing(self, args):
 
   # Tests AudioWorklet with emscripten_lock_busyspin_wait_acquire() and friends
   @requires_sound_hardware
-  @requires_shared_array_buffer
   @also_with_minimal_runtime
   def test_audio_worklet_emscripten_locks(self):
     self.btest_exit('webaudio/audioworklet_emscripten_locks.c', cflags=['-sAUDIO_WORKLET', '-sWASM_WORKERS', '-pthread'])
@@ -5626,7 +5611,6 @@ def test_rollup(self):
     '': ([], 9998),
     'es6': (['-sEXPORT_ES6', '--extern-post-js', test_file('modularize_post_js.js')], 9999),
   })
-  @requires_shared_array_buffer
   def test_cross_origin(self, args, port):
     if '-sEXPORT_ES6' in args and browser_should_skip_feature('EMTEST_LACKS_ES6_WORKERS', Feature.WORKER_ES6_MODULES):
       self.skipTest('This test requires a browser with ES6 Module Workers support')

test/test_browser.py

@@ -10073,20 +10073,18 @@ def compile(flags):
     verify_features_sec('sign-ext', False)
 
     # Disable via browser selection
-    compile(['-sMIN_SAFARI_VERSION=140000'])
-    verify_features_sec_linked('sign-ext', False)
     compile(['-sMIN_SAFARI_VERSION=140100'])
     verify_features_sec_linked('bulk-memory-opt', False)
     verify_features_sec_linked('nontrapping-fptoint', False)
     # Flag disabling overrides default browser versions
-    compile(['-mno-sign-ext'])
-    verify_features_sec_linked('sign-ext', False)
+    compile(['-mno-bulk-memory'])
+    verify_features_sec_linked('bulk-memory', False)
     # Flag disabling overrides explicit browser version
-    compile(['-sMIN_SAFARI_VERSION=160000', '-mno-sign-ext'])
-    verify_features_sec_linked('sign-ext', False)
+    compile(['-sMIN_SAFARI_VERSION=160000', '-mno-bulk-memory'])
+    verify_features_sec_linked('bulk-memory', False)
     # Flag enabling overrides explicit browser version
-    compile(['-sMIN_SAFARI_VERSION=140000', '-msign-ext'])
-    verify_features_sec_linked('sign-ext', True)
+    compile(['-sMIN_SAFARI_VERSION=140100', '-mnontrapping-fptoint'])
+    verify_features_sec_linked('nontrapping-fptoint', True)
     # Flag disabling overrides explicit version for bulk memory
     compile(['-sMIN_SAFARI_VERSION=150000', '-mno-bulk-memory'])
     verify_features_sec_linked('bulk-memory-opt', False)
@@ -13842,8 +13840,8 @@ def test_reproduce(self):
     self.assertTextDataIdentical(expected, response)
 
   def test_min_browser_version(self):
-    expected = 'emcc: error: MIN_SAFARI_VERSION=140000 is not compatible with WASM_BIGINT (MIN_SAFARI_VERSION=150000 or above required)'
-    self.assert_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-sWASM_BIGINT', '-sMIN_SAFARI_VERSION=140000'], expected)
+    expected = 'emcc: error: MIN_SAFARI_VERSION=140100 is not compatible with WASM_BIGINT (MIN_SAFARI_VERSION=150000 or above required)'
+    self.assert_fail([EMCC, test_file('hello_world.c'), '-Werror', '-sWASM_BIGINT', '-sMIN_SAFARI_VERSION=140100'], expected)
 
   # Test that using two different ways to disable a target environment at the same time will not produce a warning.
   def test_double_disable_environment(self):
@@ -13861,18 +13859,6 @@ def test_only_target_node_pthreads(self):
     self.assertContained('This page was compiled without support for Firefox browser', content)
     self.assertContained('This page was compiled without support for Chrome browser', content)
 
-  def test_signext_lowering(self):
-    # Use `-v` to show the sub-commands being run by emcc.
-    cmd = [EMCC, test_file('other/test_signext_lowering.c'), '-v']
-
-    # By default we don't expect the lowering pass to be run.
-    err = self.run_process(cmd, stderr=subprocess.PIPE).stderr
-    self.assertNotContained('--signext-lowering', err)
-
-    # Specifying an older browser version should trigger the lowering pass
-    err = self.run_process(cmd + ['-sMIN_SAFARI_VERSION=140000'], stderr=subprocess.PIPE).stderr
-    self.assertContained('--signext-lowering', err)
-
   @flaky('https://github.com/emscripten-core/emscripten/issues/20125')
   def test_itimer(self):
     self.do_other_test('test_itimer.c')

test/test_other.py

@@ -16,12 +16,9 @@
 import unittest
 
 import test_posixtest_browser
-from browser_common import browser_should_skip_feature
 from common import RunnerCore, path_from_root
 from decorators import requires_pthreads
 
-from tools.feature_matrix import Feature
-
 testsuite_root = path_from_root('test/third_party/posixtestsuite')
 
 
@@ -172,8 +169,6 @@ def make_test(name, testfile, browser):
   def f(self):
     if not NORETURN_ONLY and name in disabled:
       self.skipTest(disabled[name])
-    if browser and browser_should_skip_feature('EMTEST_LACKS_SHARED_ARRAY_BUFFER', Feature.THREADS):
-      self.skipTest('This test requires a browser with SharedArrayBuffer support')
 
     args = ['-I' + os.path.join(testsuite_root, 'include'),
             '-Werror',

test/test_posixtest.py

@@ -26,7 +26,6 @@
   requires_native_clang,
   test_file,
 )
-from test_browser import requires_shared_array_buffer
 
 from tools import config
 from tools.shared import CLANG_CC, EMCC
@@ -400,7 +399,6 @@ def test_websocket_new(self):
 
   # Test that native POSIX sockets API can be used by proxying calls to an intermediate WebSockets
   # -> POSIX sockets bridge server
-  @requires_shared_array_buffer
   def test_posix_proxy_sockets(self):
     # Build the websocket bridge server
     self.run_process(['cmake', path_from_root('tools/websocket_to_posix_proxy')])

test/test_sockets.py

@@ -521,12 +521,6 @@ def consume_arg_file():
                                     override=True)
     elif arg == '-mno-bulk-memory':
       feature_matrix.disable_feature(feature_matrix.Feature.BULK_MEMORY)
-    elif arg == '-msign-ext':
-      feature_matrix.enable_feature(feature_matrix.Feature.SIGN_EXT,
-                                    '-msign-ext',
-                                    override=True)
-    elif arg == '-mno-sign-ext':
-      feature_matrix.disable_feature(feature_matrix.Feature.SIGN_EXT)
     elif arg == '-mnontrapping-fptoint':
       feature_matrix.enable_feature(feature_matrix.Feature.NON_TRAPPING_FPTOINT,
                                     '-mnontrapping-fptoint',

tools/cmdline.py

@@ -19,18 +19,16 @@
 # MIN_x_VERSION fields to match accordingly.
 OLDEST_SUPPORTED_CHROME = 85  # Released on 2020-08-25
 OLDEST_SUPPORTED_FIREFOX = 79  # Released on 2020-07-28
-OLDEST_SUPPORTED_SAFARI = 140000  # Released on 2020-09-16
+OLDEST_SUPPORTED_SAFARI = 140100  # Released on 2021-04-26
 # This is the oldest version of node that we do any testing with.
 # Keep this in sync with the test-node-compat in .circleci/config.yml.
 OLDEST_SUPPORTED_NODE = 180300
 
 
 class Feature(IntEnum):
   NON_TRAPPING_FPTOINT = auto()
-  SIGN_EXT = auto()
   BULK_MEMORY = auto()
   JS_BIGINT_INTEGRATION = auto()
-  THREADS = auto()
   MEMORY64 = auto()
   WORKER_ES6_MODULES = auto()
   OFFSCREENCANVAS_SUPPORT = auto()
@@ -44,19 +42,14 @@ class Feature(IntEnum):
 disable_override_features = set()
 enable_override_features = set()
 
+
 min_browser_versions = {
   Feature.NON_TRAPPING_FPTOINT: {
     'chrome': 75,
     'firefox': 65,
     'safari': 150000,
     'node': 130000,
   },
-  Feature.SIGN_EXT: {
-    'chrome': 74,
-    'firefox': 62,
-    'safari': 140100,
-    'node': 120000,
-  },
   Feature.BULK_MEMORY: {
     'chrome': 75,
     'firefox': 79,
@@ -69,12 +62,6 @@ class Feature(IntEnum):
     'safari': 150000,
     'node': 130000,
   },
-  Feature.THREADS: {
-    'chrome': 74,
-    'firefox': 79,
-    'safari': 140100,
-    'node': 160400,
-  },
   Feature.MEMORY64: {
     'chrome': 128,
     'firefox': 129,
@@ -146,6 +133,38 @@ class Feature(IntEnum):
     'safari': UNSUPPORTED,
     'node': 240000,
   },
+
+# The following features we now support unconditaionlly, but keeping them around
+# in code comments for future reference
+
+#  Feature.MUTABLE_GLOBALS: {
+#    'chrome': 74,
+#    'firefox': 61,
+#    'safari': 130100,
+#    'node': 120000,
+#  },
+
+#  Feature.SIGN_EXT: {
+#    'chrome': 74,
+#    'firefox': 62,
+#    'safari': 140100,
+#    'node': 120000,
+#  },
+
+#  Feature.THREADS: {
+#    'chrome': 74,
+#    'firefox': 79,
+#    'safari': 140100,
+#    'node': 160400,
+#  },
+
+#  Feature.PROMISE_ANY: {
+#    'chrome': 85,
+#    'firefox': 79,
+#    'safari': 140000,
+#    'node': 150000,
+#  },
+
 }
 
 # Static assertion to check that we actually need each of the above feature flags
@@ -225,7 +244,6 @@ def apply_min_browser_versions():
     # unless the user explicitly enabled it.
     enable_feature(Feature.JS_BIGINT_INTEGRATION, 'WASM_BIGINT')
   if settings.PTHREADS:
-    enable_feature(Feature.THREADS, 'pthreads')
     enable_feature(Feature.BULK_MEMORY, 'pthreads')
   elif settings.WASM_WORKERS or settings.SHARED_MEMORY:
     enable_feature(Feature.BULK_MEMORY, 'shared-mem')