Skip to content

Commit 1015967

Browse files
authored
Fix test_wasm_bindgen_integration. NFC (#27081)
Without this change the test was failing on my local machine due to missing wasm-bindgen. An alternative would be to have a way to opt out, but its seems easy enough to run the `install` as part of the test.
1 parent a30a119 commit 1015967

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

.circleci/config.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ commands:
7272
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
7373
export PATH=${HOME}/.cargo/bin:${PATH}
7474
rustup target add wasm32-unknown-emscripten
75-
cargo install wasm-bindgen-cli
7675
echo "export PATH=\"\$HOME/.cargo/bin:\$PATH\"" >> $BASH_ENV
7776
install-node-version:
7877
description: "install a specific version of node"

test/test_other.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14842,9 +14842,9 @@ def test_wasm_bindgen_integration(self):
1484214842
create_file('post.js', '''
1484314843
Module.onRuntimeInitialized = () => out(Module.rs_add(17, 25));
1484414844
''')
14845-
emcc_args = [lib, '-sWASM_BINDGEN', '--post-js=post.js', '-lexports.js']
1484614845

14847-
self.do_runf('empty.c', '42', cflags=emcc_args)
14846+
self.run_process(['cargo', 'install', 'wasm-bindgen-cli'])
14847+
self.do_runf('empty.c', '42', cflags=[lib, '-sWASM_BINDGEN', '--post-js=post.js', '-lexports.js'])
1484814848

1484914849
def test_relative_em_cache(self):
1485014850
with env_modify({'EM_CACHE': 'foo'}):

0 commit comments

Comments
 (0)