Skip to content

Commit 23ec527

Browse files
authored
Mark dynamic linking as requiring async compilation (#27086)
The loading of the dynamic libraries on startup has always been async but now we make a clear error to use `-sWASM_ASYNC_COMPILATION=0` with dynamic linking. Split out from #27079
1 parent 1015967 commit 23ec527

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

ChangeLog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ See docs/process.md for more on how version tagging works.
2020

2121
6.0.1 (in development)
2222
----------------------
23+
- Dynamic linking now explicitly requires asynchronous Wasm compilation. The
24+
process of loading side modules at startup currently depends on this. (#27086)
2325
- The `-sUSE_PTHREADS` and `-sMEMORY64` flags have been deprecated in favor of the
2426
more standard `-pthread` and `-m64` (or `--target=wasm64`) flags. (#27025)
2527
- Adds wasm-bindgen support. When `-sWASM_BINDGEN` is set, Emscripten will call

tools/settings.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@
131131
('WASM_WORKERS', 'MAIN_MODULE', 'dynamic linking is not supported with -sWASM_WORKERS'),
132132
('WASM2JS', 'MAIN_MODULE', 'wasm2js does not support dynamic linking'),
133133
('WASM2JS', 'SIDE_MODULE', 'wasm2js does not support dynamic linking'),
134+
('MAIN_MODULE', 'NO_WASM_ASYNC_COMPILATION', 'dynamic linking requires async wasm compilation'),
134135
('MODULARIZE', 'NO_DECLARE_ASM_MODULE_EXPORTS', None),
135136
('EVAL_CTORS', 'WASM2JS', None),
136137
# In Asyncify exports can be called more than once, and this seems to not

0 commit comments

Comments
 (0)