Commit 48a0bbd
authored
Fix closure compiler warnings with -sFULL_ES3 (#26893)
Without this we see
```
building:ERROR: /tmp/emscripten_temp/hello_world.js:14723:8: WARNING - [JSC_UNREACHABLE_CODE] unreachable code
14723| GLctx.bufferSubData(target, mapping.offset, HEAPU8.subarray(mapping.mem, mapping.mem+mapping.length));
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
The `if/else` stuff around `GLctx.bufferSubData` is pretty nasty so I
have a followup to tidy it up.
Also, include more of webgl in test_codesize_hello_dylink_all. It
obviously gets much bigger but its also means that we can use this to
observe codesize changes in more library code.1 parent 101b333 commit 48a0bbd
6 files changed
Lines changed: 346 additions & 7 deletions
File tree
- src/lib
- test
- codesize
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| 84 | + | |
84 | 85 | | |
85 | 86 | | |
86 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3825 | 3825 | | |
3826 | 3826 | | |
3827 | 3827 | | |
3828 | | - | |
| 3828 | + | |
3829 | 3829 | | |
3830 | 3830 | | |
3831 | 3831 | | |
| |||
4262 | 4262 | | |
4263 | 4263 | | |
4264 | 4264 | | |
4265 | | - | |
| 4265 | + | |
| 4266 | + | |
| 4267 | + | |
4266 | 4268 | | |
| 4269 | + | |
| 4270 | + | |
4267 | 4271 | | |
| 4272 | + | |
4268 | 4273 | | |
4269 | 4274 | | |
4270 | 4275 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
930 | 930 | | |
931 | 931 | | |
932 | 932 | | |
933 | | - | |
| 933 | + | |
934 | 934 | | |
935 | 935 | | |
936 | 936 | | |
| |||
0 commit comments