Skip to content

Commit 61da1f9

Browse files
committed
Fix EMTEST_BROWSER lookup.
1 parent 4aed2bb commit 61da1f9

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

test/browser_common.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -332,12 +332,13 @@ def configure_test_browser():
332332
if not has_browser():
333333
return
334334

335-
EMTEST_BROWSER = 'google-chrome'
336-
if not shutil.which(EMTEST_BROWSER):
337-
EMTEST_BROWSER = 'firefox'
335+
if not EMTEST_BROWSER:
336+
EMTEST_BROWSER = 'google-chrome'
338337
if not shutil.which(EMTEST_BROWSER):
339-
# FIXME: This should really be and error, but this code currently also runs for non-browser tests.
340-
EMTEST_BROWSER = 'default-browser-not-found'
338+
EMTEST_BROWSER = 'firefox'
339+
if not shutil.which(EMTEST_BROWSER):
340+
# FIXME: This should really be and error, but this code currently also runs for non-browser tests.
341+
EMTEST_BROWSER = 'default-browser-not-found'
341342

342343
if WINDOWS and '"' not in EMTEST_BROWSER and "'" not in EMTEST_BROWSER:
343344
# On Windows env. vars canonically use backslashes as directory delimiters, e.g.

0 commit comments

Comments
 (0)