Skip to content

Commit 6d16622

Browse files
authored
Add core0ss testing mode. NFC (#26874)
Also, update the skip for test_pthread_dylink_tls (it fails regardless of opt level). See #24964.
1 parent 6085102 commit 6d16622

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

test/test_core.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9364,7 +9364,7 @@ def test_pthread_dlsym(self):
93649364
@needs_dylink
93659365
@requires_pthreads
93669366
def test_pthread_dylink_tls(self):
9367-
if '-O2' in self.cflags and self.get_setting('STACK_OVERFLOW_CHECK') == 2:
9367+
if self.get_setting('STACK_OVERFLOW_CHECK') == 2:
93689368
self.skipTest('https://github.com/emscripten-core/emscripten/issues/24964: fails with stack overflow (Attempt to set SP to 0x000114d0, with stack limits [0x00000000 - 0x00000000])')
93699369

93709370
self.cflags += ['-Wno-experimental', '-pthread']
@@ -9964,6 +9964,7 @@ def setUp(self):
99649964
# SAFE_HEAP/STACK_OVERFLOW_CHECK
99659965
core0s = make_run('core0s', cflags=['-g'], settings={'SAFE_HEAP': 1})
99669966
core2s = make_run('core2s', cflags=['-O2'], settings={'SAFE_HEAP': 1})
9967+
core0ss = make_run('core0ss', cflags=['-g'], settings={'STACK_OVERFLOW_CHECK': 2})
99679968
core2ss = make_run('core2ss', cflags=['-O2'], settings={'STACK_OVERFLOW_CHECK': 2})
99689969

99699970
esm_integration = make_run('esm_integration', init=lambda self: self.setup_esm_integration())

0 commit comments

Comments
 (0)