Skip to content

Commit 7abb9b5

Browse files
committed
Adjust autolookup for EMTEST_BROWSER to avoid PATH
1 parent 2dca116 commit 7abb9b5

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

test/browser_common.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -332,11 +332,11 @@ def configure_test_browser():
332332
if not has_browser():
333333
return
334334

335-
if not EMTEST_BROWSER:
336-
EMTEST_BROWSER = shutil.which('google-chrome')
337-
if not EMTEST_BROWSER:
338-
EMTEST_BROWSER = shutil.which('firefox')
339-
if not EMTEST_BROWSER:
335+
EMTEST_BROWSER = 'google-chrome'
336+
if not shutil.which(EMTEST_BROWSER):
337+
EMTEST_BROWSER = 'firefox'
338+
if not shutil.which(EMTEST_BROWSER):
339+
# FIXME: This should really be and error, but this code currently also runs for non-browser tests.
340340
EMTEST_BROWSER = 'default-browser-not-found'
341341

342342
if WINDOWS and '"' not in EMTEST_BROWSER and "'" not in EMTEST_BROWSER:

0 commit comments

Comments
 (0)