Skip to content

Commit 8b99732

Browse files
authored
test_benchmark.py: Don't pass args to benchmark build method (#26292)
The `args` here are the runtime command line args for the benchmark program, not compiler flags, so do no need to be passed to the `build` method, and indeed are not used in any of them. The args here is normally just `[DEFAULT_ARG]` which is `['4']` which would not make any sense as a compiler arg in any case.
1 parent 4f10a0d commit 8b99732

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

test/test_benchmark.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def __init__(self, name, cc, cxx, args=None):
161161
self.cxx = cxx
162162
self.args = args or [OPTIMIZATIONS]
163163

164-
def build(self, parent, filename, args, shared_args, emcc_args, native_args, native_exec, lib_builder):
164+
def build(self, parent, filename, shared_args, emcc_args, native_args, native_exec, lib_builder):
165165
native_args = native_args or []
166166
shared_args = shared_args or []
167167
self.parent = parent
@@ -214,7 +214,7 @@ def __init__(self, name, engine, extra_args=None, env=None, binaryen_opts=None):
214214
self.env.update(env)
215215
self.binaryen_opts = binaryen_opts or []
216216

217-
def build(self, parent, filename, args, shared_args, emcc_args, native_args, native_exec, lib_builder):
217+
def build(self, parent, filename, shared_args, emcc_args, native_args, native_exec, lib_builder):
218218
emcc_args = emcc_args or []
219219
self.filename = filename
220220
llvm_root = self.env.get('LLVM') or config.LLVM_ROOT
@@ -295,7 +295,7 @@ def __init__(self, name, engine, args=None, binaryen_opts=None):
295295
self.args = args or [OPTIMIZATIONS]
296296
self.binaryen_opts = binaryen_opts or []
297297

298-
def build(self, parent, filename, args, shared_args, emcc_args, native_args, native_exec, lib_builder):
298+
def build(self, parent, filename, shared_args, emcc_args, native_args, native_exec, lib_builder):
299299
cheerp_args = [
300300
'-fno-math-errno',
301301
]
@@ -457,7 +457,7 @@ def do_benchmark(self, name, src, expected_output='FAIL', args=None,
457457
reps = 0
458458
baseline = b
459459
print('Running benchmarker: %s: %s' % (b.__class__.__name__, b.name))
460-
b.build(self, filename, args, shared_args, emcc_args, native_args, native_exec, lib_builder)
460+
b.build(self, filename, shared_args, emcc_args, native_args, native_exec, lib_builder)
461461
b.bench(args, output_parser, reps, expected_output)
462462
recorded_stats = b.display(baseline)
463463
if recorded_stats:

0 commit comments

Comments
 (0)